Description

Fix and update ppom-middleware tests

Fix:

• test with usePPOM did not test expected thown error
  • great find by @cryptotavares
  • test was throwing an unexpected error rather than the thrown error in the mocked method
  • the error was passing the usePPOM param as an object rather than a promise
• validation test did not test validation, but rather loading. Updated test to reflect testing loading
• added validation test
• test to check non-supported network was faulty
  • updated phrase to mention non-supported networks rather than non-eth-mainnet networks
  • removed securityProviderEnabled: false check, which blocked the test from testing

Updates:

• remove "should" prefix from test phrases
• updates createMiddleware helper method to use an options param for optional parameters

Related issues

Fixes: #23571
Related to: #23480

Manual testing steps

1. yarn jest app/scripts/lib/ppom/ppom-middleware.test.ts

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.