Skip to content

chore: improves mmi flow#23735

Merged
zone-live merged 2 commits intodevelopfrom
MMI-fix-mmi-e2e-pipeline
Mar 27, 2024
Merged

chore: improves mmi flow#23735
zone-live merged 2 commits intodevelopfrom
MMI-fix-mmi-e2e-pipeline

Conversation

@zone-live
Copy link
Copy Markdown
Contributor

Description

Fixes/improves MMI flow during onboarding.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@zone-live zone-live requested a review from a team as a code owner March 26, 2024 17:27
@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@zone-live zone-live added the mmi DEPRECATED: The product got sunset label Mar 26, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [fc94197]
Page Load Metrics (674 ± 432 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint723681206230
domContentLoaded1084332211
load592469674900432
domInteractive1084322211
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [abbc458]
Page Load Metrics (742 ± 472 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint663661316230
domContentLoaded106130168
load502588742983472
domInteractive106129168
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.20%. Comparing base (0a3ef25) to head (abbc458).
Report is 6 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #23735   +/-   ##
========================================
  Coverage    69.20%   69.20%           
========================================
  Files         1160     1160           
  Lines        44146    44146           
  Branches     11797    11797           
========================================
  Hits         30551    30551           
  Misses       13595    13595           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zone-live zone-live merged commit 18fdd28 into develop Mar 27, 2024
@zone-live zone-live deleted the MMI-fix-mmi-e2e-pipeline branch March 27, 2024 09:44
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2024
@metamaskbot metamaskbot added the release-11.15.0 Issue or pull request that will be included in release 11.15.0 label Mar 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

mmi DEPRECATED: The product got sunset release-11.15.0 Issue or pull request that will be included in release 11.15.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants