chore: fix storybook css rendering caused updating css-loader#23734
Merged
davidmurdoch merged 2 commits intodevelopfrom Mar 26, 2024
Merged
chore: fix storybook css rendering caused updating css-loader#23734davidmurdoch merged 2 commits intodevelopfrom
davidmurdoch merged 2 commits intodevelopfrom
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
dbrans
approved these changes
Mar 26, 2024
georgewrmarshall
approved these changes
Mar 26, 2024
Contributor
georgewrmarshall
left a comment
There was a problem hiding this comment.
LGTM! Thanks @davidmurdoch 🚀
Collaborator
Builds ready [e773c3c]
Page Load Metrics (823 ± 480 ms)
Bundle size diffs
|
Contributor
|
I think we can merge this but noticed that fonts aren't loading on the storybook build of this PR. Let's see if it's just a PR build issue or a github pages when this has been merged https://output.circle-artifacts.com/output/job/c909b8ed-98d0-4d29-a478-3eca63daebae/artifacts/0/storybook/index.html?path=/story/components-componentlibrary-banneralert--default-story |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default value for the
esModuleoption forcss-loaderchanged from v2 to v6 but I didn't update it when I updated the package in #23667.