Skip to content

fix: UX: Multichain: Only show connection toast on the home screen#23733

Merged
darkwing merged 3 commits intodevelopfrom
home-screen-connect-toast
Apr 10, 2024
Merged

fix: UX: Multichain: Only show connection toast on the home screen#23733
darkwing merged 3 commits intodevelopfrom
home-screen-connect-toast

Conversation

@darkwing
Copy link
Copy Markdown
Contributor

@darkwing darkwing commented Mar 26, 2024 •
edited by github-actions bot
Loading

Description

This PR ensures that the "Connect Account" toast only displays on the home screen (i.e. not on the send screen, swap screen, connections screen, etc)

Open in GitHub Codespaces

Related issues

Fixes: N/A

Manual testing steps

  1. Go to any dapp
  2. Connect Account 1
  3. Switch to Account 2 in MetaMask popup
  4. See the Connection toast
  5. Click the Swaps button
  6. Don't see the Connection toast anymore

Screenshots/Recordings

Before

After

Screen.Recording.2024-03-26.at.12.13.51.PM.mov

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@darkwing darkwing requested a review from a team as a code owner March 26, 2024 17:23
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 26, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@darkwing darkwing changed the title UX: Multichain: Only show connection toast on the home screen fix: UX: Multichain: Only show connection toast on the home screen Mar 26, 2024
@darkwing darkwing added team-core-extension-ux Core Extension UX team needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. labels Mar 26, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Mar 27, 2024

Builds ready [629a63a]
Page Load Metrics (940 ± 509 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint664481559345
domContentLoaded1090302311
load5326589401061509
domInteractive1090302311
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 101 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 27, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 69.19%. Comparing base (3f1dd0c) to head (629a63a).
Report is 1 commits behind head on develop.

Files Patch % Lines
ui/pages/routes/routes.component.js 16.67% 5 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #23733      +/-   ##
===========================================
- Coverage    69.20%   69.19%   -0.01%     
===========================================
  Files         1160     1160              
  Lines        44182    44187       +5     
  Branches     11814    11816       +2     
===========================================
  Hits         30573    30573              
- Misses       13609    13614       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@darkwing darkwing merged commit 28f16b2 into develop Apr 10, 2024
@darkwing darkwing deleted the home-screen-connect-toast branch April 10, 2024 14:59
@github-actions github-actions bot locked and limited conversation to collaborators Apr 10, 2024
@metamaskbot metamaskbot added the release-11.15.0 Issue or pull request that will be included in release 11.15.0 label Apr 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@NidhiKJha NidhiKJha NidhiKJha approved these changes

+1 more reviewer

@vthomas13 vthomas13 vthomas13 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-11.15.0 Issue or pull request that will be included in release 11.15.0 team-core-extension-ux Core Extension UX team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@darkwing @metamaskbot @vthomas13 @NidhiKJha