Skip to content

fix: patch controller-utils to add linea sepolia network type#23727

Merged
sahar-fehri merged 1 commit intodevelopfrom
fix/patch-controller-utils
Mar 26, 2024
Merged

fix: patch controller-utils to add linea sepolia network type#23727
sahar-fehri merged 1 commit intodevelopfrom
fix/patch-controller-utils

Conversation

@sahar-fehri
Copy link
Copy Markdown
Contributor

@sahar-fehri sahar-fehri commented Mar 26, 2024 •
edited by github-actions bot
Loading

Description

Creates a patch for controller-utils to be able to get "linea-sepolia" from NetworkType

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@sahar-fehri sahar-fehri requested a review from a team as a code owner March 26, 2024 14:44
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 26, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sahar-fehri sahar-fehri added needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. team-assets labels Mar 26, 2024
@sahar-fehri sahar-fehri force-pushed the fix/patch-controller-utils branch from 5b0524f to e01151a Compare March 26, 2024 15:24
@sahar-fehri sahar-fehri force-pushed the fix/patch-controller-utils branch from af99ae2 to 0f7f3fe Compare March 26, 2024 15:27
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Mar 26, 2024

Builds ready [0f7f3fe]
Page Load Metrics (937 ± 497 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint683421386632
domContentLoaded1095312110
load5623649371035497
domInteractive1095312110
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 32 Bytes (0.00%)

@sahar-fehri sahar-fehri merged commit 0a3ef25 into develop Mar 26, 2024
@sahar-fehri sahar-fehri deleted the fix/patch-controller-utils branch March 26, 2024 17:03
@github-actions github-actions bot locked and limited conversation to collaborators Mar 26, 2024
@metamaskbot metamaskbot added the release-11.15.0 Issue or pull request that will be included in release 11.15.0 label Mar 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@darkwing darkwing darkwing approved these changes

@bergeron bergeron bergeron approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-11.15.0 Issue or pull request that will be included in release 11.15.0 team-assets

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sahar-fehri @metamaskbot @darkwing @bergeron