Skip to content

chore: MMI adds second transaction e2e test#23721

Merged
zone-live merged 2 commits intodevelopfrom
MMI-4759-add-e2e-test-related-with-tx
Mar 27, 2024
Merged

chore: MMI adds second transaction e2e test#23721
zone-live merged 2 commits intodevelopfrom
MMI-4759-add-e2e-test-related-with-tx

Conversation

@zone-live
Copy link
Copy Markdown
Contributor

@zone-live zone-live commented Mar 26, 2024

Description

Adds e2e test for MMI. It sends out a second transaction, while having one created already.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@zone-live zone-live added the mmi DEPRECATED: The product got sunset label Mar 26, 2024
@zone-live zone-live requested a review from a team as a code owner March 26, 2024 11:30
@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [77c1d2b]
Page Load Metrics (1502 ± 622 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint833361607034
domContentLoaded168531178
load68340515021295622
domInteractive168531178
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.20%. Comparing base (3dbe2e6) to head (413fa3c).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #23721   +/-   ##
========================================
  Coverage    69.20%   69.20%           
========================================
  Files         1160     1160           
  Lines        44182    44182           
  Branches     11814    11814           
========================================
  Hits         30573    30573           
  Misses       13609    13609           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zone-live zone-live requested a review from NidhiKJha March 26, 2024 11:39
@zone-live zone-live requested a review from DDDDDanica March 26, 2024 14:44
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [413fa3c]
Page Load Metrics (1354 ± 502 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint702961466330
domContentLoaded1088272110
load57266913541046502
domInteractive1088272110
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@zone-live zone-live merged commit 3f1dd0c into develop Mar 27, 2024
@zone-live zone-live deleted the MMI-4759-add-e2e-test-related-with-tx branch March 27, 2024 10:43
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2024
@metamaskbot metamaskbot added the release-11.15.0 Issue or pull request that will be included in release 11.15.0 label Mar 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

mmi DEPRECATED: The product got sunset release-11.15.0 Issue or pull request that will be included in release 11.15.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants