Skip to content

fix:UX: MULTICHAIN: Updated the active logic for connected accounts#23720

Merged
NidhiKJha merged 3 commits intodevelopfrom
connected-active-status
Mar 26, 2024
Merged

fix:UX: MULTICHAIN: Updated the active logic for connected accounts#23720
NidhiKJha merged 3 commits intodevelopfrom
connected-active-status

Conversation

@NidhiKJha
Copy link
Copy Markdown
Member

@NidhiKJha NidhiKJha commented Mar 26, 2024 •
edited
Loading

This PR ensures that we have correct active status for connected accounts

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2309

Manual testing steps

  1. Run extension with Multichain Flag
  2. connect with a dapp
  3. in the account list menu, the last selected connected account, should be active.
  4. If the currently selected account is connected, it should be active
  5. Check same for connections page

Screenshots/Recordings

Before

NA

After

Screen.Recording.2024-03-26.at.4.55.20.PM.mov

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@NidhiKJha NidhiKJha requested a review from a team as a code owner March 26, 2024 11:26
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Mar 26, 2024
@NidhiKJha NidhiKJha added team-core-extension-ux Core Extension UX team needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. labels Mar 26, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 69.28%. Comparing base (8b12ade) to head (49665c8).
Report is 1 commits behind head on develop.

Files Patch % Lines
...nents/multichain/pages/connections/connections.tsx 75.00% 3 Missing ⚠️
ui/selectors/selectors.js 84.62% 2 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #23720   +/-   ##
========================================
  Coverage    69.28%   69.28%           
========================================
  Files         1158     1158           
  Lines        44069    44089   +20     
  Branches     11758    11765    +7     
========================================
+ Hits         30531    30545   +14     
- Misses       13538    13544    +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Mar 26, 2024

Builds ready [49665c8]
Page Load Metrics (578 ± 401 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint633821327134
domContentLoaded1094392311
load512187578834401
domInteractive1094392311
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 395 Bytes (0.01%)
  • common: 0 Bytes (0.00%)

darkwing
darkwing approved these changes Mar 26, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@darkwing darkwing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving now but I think we should explore simplifying the getUpdatedAndSortedAccounts selector if possible.

@NidhiKJha NidhiKJha merged commit 17abe58 into develop Mar 26, 2024
@NidhiKJha NidhiKJha deleted the connected-active-status branch March 26, 2024 17:48
@github-actions github-actions bot locked and limited conversation to collaborators Mar 26, 2024
@metamaskbot metamaskbot added the release-11.15.0 Issue or pull request that will be included in release 11.15.0 label Mar 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@darkwing darkwing darkwing approved these changes

@vthomas13 vthomas13 vthomas13 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-11.15.0 Issue or pull request that will be included in release 11.15.0 team-core-extension-ux Core Extension UX team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@NidhiKJha @metamaskbot @darkwing @vthomas13