feat: add inline alert to confirm AlertRow component#23719
Merged
vinistevam merged 86 commits intodevelopfrom May 9, 2024
Merged
feat: add inline alert to confirm AlertRow component#23719vinistevam merged 86 commits intodevelopfrom
AlertRow component#23719vinistevam merged 86 commits intodevelopfrom
Conversation
…lert-modal-component
…lert-modal-component
…ne-alert-info-row-component
…ne-alert-info-row-component
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #23719 +/- ##
===========================================
- Coverage 67.35% 67.35% -0.00%
===========================================
Files 1285 1286 +1
Lines 50113 50142 +29
Branches 13004 13014 +10
===========================================
+ Hits 33753 33771 +18
- Misses 16360 16371 +11 ☔ View full report in Codecov by Sentry. |
…al.tsx Co-authored-by: Matthew Walsh <matthew.walsh@consensys.net>
…al.tsx Co-authored-by: Matthew Walsh <matthew.walsh@consensys.net>
The base branch was changed.
4d48f9b to
91aefe6
Compare
matthewwalsh0
approved these changes
May 8, 2024
OGPoyraz
approved these changes
May 8, 2024
Collaborator
Builds ready [3838c09]
Page Load Metrics (1567 ± 653 ms)
Bundle size diffs
|
Collaborator
|
Missing release label release-11.17.0 on PR. Adding release label release-11.17.0 on PR and removing other release labels(release-11.18.0), as PR was added to branch 11.17.0 when release was cut. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to include alongside the
AlertRowcomponent theInlineAlertcomponent and adapt the styling accordingly based on the severity.Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2262
Manual testing steps
This component is currently not in use and is not available to users. It is part of the new alert system, and we will have a dedicated PR to integrate this component into the new confirmation screens.
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist