Skip to content

fix: layout of security alerts option on settings page#23718

Merged
jpuri merged 2 commits intodevelopfrom
settings_page_fix
Mar 26, 2024
Merged

fix: layout of security alerts option on settings page#23718
jpuri merged 2 commits intodevelopfrom
settings_page_fix

Conversation

@jpuri
Copy link
Copy Markdown
Contributor

@jpuri jpuri commented Mar 26, 2024 •
edited
Loading

Description

Fix layout of security alert option.

Related issues

Fixes: #23684

Manual testing steps

  1. Go to security tab in settings
  2. Check layout of security alert option

Screenshots/Recordings

Screenshot 2024-03-26 at 2 49 12 PM

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added team-confirmations-secure-ux-PR PRs from the confirmations team needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Mar 26, 2024
@jpuri jpuri requested a review from a team as a code owner March 26, 2024 09:18
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 26, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Mar 26, 2024

Builds ready [8222fb3]
Page Load Metrics (613 ± 433 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint672181243718
domContentLoaded116531178
load542391613901433
domInteractive116531178
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 158 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.28%. Comparing base (8b12ade) to head (8222fb3).
Report is 1 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #23718   +/-   ##
========================================
  Coverage    69.28%   69.28%           
========================================
  Files         1158     1158           
  Lines        44069    44069           
  Branches     11758    11758           
========================================
  Hits         30531    30531           
  Misses       13538    13538

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jpuri jpuri merged commit cd9bdfa into develop Mar 26, 2024
@jpuri jpuri deleted the settings_page_fix branch March 26, 2024 14:33
@github-actions github-actions bot locked and limited conversation to collaborators Mar 26, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 26, 2024
@metamaskbot metamaskbot added the release-11.15.0 Issue or pull request that will be included in release 11.15.0 label Mar 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@pedronfigueiredo pedronfigueiredo pedronfigueiredo approved these changes

+1 more reviewer

@blackdevelopa blackdevelopa blackdevelopa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-11.15.0 Issue or pull request that will be included in release 11.15.0 team-confirmations-secure-ux-PR PRs from the confirmations team

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Security alerts using incorrect alignment and wrong toggle placement

4 participants

@jpuri @metamaskbot @pedronfigueiredo @blackdevelopa