feat: replace confirmation re-design code fencing with env variable#23694
Merged
feat: replace confirmation re-design code fencing with env variable#23694
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
segun
previously approved these changes
Mar 25, 2024
digiwand
reviewed
Mar 25, 2024
| import { renderHookWithProvider } from '../../../../test/lib/render-helpers'; | ||
| import useCurrentConfirmation from './useCurrentConfirmation'; | ||
|
|
||
| process.env.ENABLE_CONFIRMATION_REDESIGN = 'true'; |
Contributor
There was a problem hiding this comment.
have we considered restoring the value after the tests have finished? e.g. in an afterAll hook
Contributor
Author
There was a problem hiding this comment.
Good point, I updated the PR.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #23694 +/- ##
===========================================
- Coverage 68.81% 68.81% -0.00%
===========================================
Files 1169 1169
Lines 44376 44378 +2
Branches 11874 11875 +1
===========================================
Hits 30536 30536
- Misses 13840 13842 +2 ☔ View full report in Codecov by Sentry. |
pedronfigueiredo
approved these changes
Mar 26, 2024
segun
approved these changes
Mar 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add env variable to enable confirmation re-design and remove code fencing.
Related issues
Fixes: #23600
Manual testing steps
ENABLE_CONFIRMATION_REDESIGNlocally and start the appScreenshots/Recordings
NA
Pre-merge author checklist
Pre-merge reviewer checklist