Skip to content

fix: crypto balance should be displayed if we have scam network warning#23645

Merged
salimtb merged 1 commit intodevelopfrom
fix-show-crypto-balance-for-scam-network
Mar 26, 2024
Merged

fix: crypto balance should be displayed if we have scam network warning#23645
salimtb merged 1 commit intodevelopfrom
fix-show-crypto-balance-for-scam-network

Conversation

@salimtb
Copy link
Copy Markdown
Contributor

@salimtb salimtb commented Mar 22, 2024 •
edited by github-actions bot
Loading

Description

the crypto balance is not displayed correctly when there's a scam warning on the network.

Open in GitHub Codespaces

Related issues

Fixes: #23644 23644

Manual testing steps

  1. Go to Netwrok edit and choose polygon
  2. change symbol from MATIC to ETH
  3. go to general settings
  4. change crypto primary toggle from fiat to Crypto
  5. go to the wallet page and check the crypto balance

Screenshots/Recordings

Before

before.mov

After

after.mov

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@salimtb salimtb requested a review from a team as a code owner March 22, 2024 10:43
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 22, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@salimtb salimtb added team-assets needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. labels Mar 22, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 22, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 68.58%. Comparing base (a246dc3) to head (db1b559).
Report is 1 commits behind head on develop.

Files Patch % Lines
...ents/multichain/token-list-item/token-list-item.js 85.71% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #23645      +/-   ##
===========================================
+ Coverage    68.57%   68.58%   +0.01%     
===========================================
  Files         1163     1163              
  Lines        44134    44141       +7     
  Branches     11813    11819       +6     
===========================================
+ Hits         30262    30273      +11     
+ Misses       13872    13868       -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@salimtb salimtb requested review from bergeron and sahar-fehri March 22, 2024 11:13
@sahar-fehri
Copy link
Copy Markdown
Contributor

sahar-fehri commented Mar 22, 2024 •
edited
Loading

Depending on whether the user chooses "ETH" or "Fiat" in the settings we either show:
-ETH
-USD
OR
-USD
-ETH
I kinda expected to see the warning icon below "ETH" when the user chose "ETH" in the second video

@salimtb salimtb self-assigned this Mar 24, 2024
@DDDDDanica
Copy link
Copy Markdown
Contributor

DDDDDanica commented Mar 25, 2024

LGTM !

@DDDDDanica DDDDDanica closed this Mar 25, 2024
@DDDDDanica DDDDDanica reopened this Mar 25, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 25, 2024
@salimtb salimtb requested a review from a team March 25, 2024 17:24
@salimtb salimtb merged commit fe43c2e into develop Mar 26, 2024
@salimtb salimtb deleted the fix-show-crypto-balance-for-scam-network branch March 26, 2024 14:55
@metamaskbot metamaskbot added the release-11.15.0 Issue or pull request that will be included in release 11.15.0 label Mar 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DDDDDanica DDDDDanica DDDDDanica approved these changes

@bergeron bergeron Awaiting requested review from bergeron

@sahar-fehri sahar-fehri Awaiting requested review from sahar-fehri

+1 more reviewer

@darkwing darkwing darkwing approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@salimtb salimtb

Labels

needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-11.15.0 Issue or pull request that will be included in release 11.15.0 team-assets

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: crypto balance not displayed in case of warning scam network

5 participants

@salimtb @sahar-fehri @DDDDDanica @darkwing @metamaskbot