feat: Release Transaction Insights V2 & Signature Insights to stable#23630
Merged
feat: Release Transaction Insights V2 & Signature Insights to stable#23630
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Member
FrederikBolding
left a comment
There was a problem hiding this comment.
@hmalik88 The signature insight permission needs to be unfenced and removed from excluded permissions too
Member
FrederikBolding
left a comment
There was a problem hiding this comment.
Please enable the E2Es in stable as well:
https://github.com/MetaMask/metamask-extension/blob/develop/test/e2e/run-all.js#L12
https://github.com/MetaMask/metamask-extension/blob/develop/test/e2e/run-all.js#L14
Collaborator
Builds ready [42d2931]
Page Load Metrics (682 ± 497 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #23630 +/- ##
========================================
Coverage 67.54% 67.55%
========================================
Files 1245 1245
Lines 48866 48861 -5
Branches 12744 12743 -1
========================================
- Hits 33005 33004 -1
+ Misses 15861 15857 -4 ☔ View full report in Codecov by Sentry. |
FrederikBolding
previously approved these changes
Apr 12, 2024
Mrtenz
previously approved these changes
Apr 12, 2024
FrederikBolding
previously approved these changes
Apr 12, 2024
Collaborator
Builds ready [e8ddef0]
Page Load Metrics (1055 ± 512 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Collaborator
Builds ready [ae8ec04]
Page Load Metrics (1394 ± 568 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
david0xd
approved these changes
Apr 12, 2024
FrederikBolding
approved these changes
Apr 12, 2024
OGPoyraz
approved these changes
Apr 15, 2024
jpuri
approved these changes
Apr 15, 2024
Contributor
jpuri
left a comment
There was a problem hiding this comment.
I reviewed the changes in part of code owned by confirmations team ui/pages/confirmations/.., those look good 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Transaction insight logic was refactored and fencing for both transaction and signature insights was
updatedremoved to bring the features into stable.