feat: UX MULTICHAIN: Added toast in the connections flow components#23624
Merged
feat: UX MULTICHAIN: Added toast in the connections flow components#23624
Conversation
Collaborator
Builds ready [ba59b43]
Page Load Metrics (1487 ± 671 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #23624 +/- ##
===========================================
- Coverage 69.21% 69.20% -0.01%
===========================================
Files 1160 1160
Lines 44158 44177 +19
Branches 11803 11809 +6
===========================================
+ Hits 30562 30570 +8
- Misses 13596 13607 +11 ☔ View full report in Codecov by Sentry. |
darkwing
reviewed
Mar 25, 2024
| /** | ||
| * Function to set account name to show disconnect toast when an account is disconnected | ||
| */ | ||
| onActionClick: PropTypes.func, |
Contributor
There was a problem hiding this comment.
This should be isRequired if we don't have a default value.
Contributor
There was a problem hiding this comment.
Instead of assuming onActionClick is there, and passing () => null args, can we do:
onActionClick?.()
Member
Author
There was a problem hiding this comment.
I updated toast to use actionClick as optional prop b9b247b
darkwing
reviewed
Mar 25, 2024
| disableAccountSwitcher: boolean; | ||
| onClose: () => void; | ||
| closeMenu: () => void; | ||
| onActionClick: (mesg: string) => void; |
Contributor
There was a problem hiding this comment.
Total nit but can this be message? Abbreviations like this aren't necessary.
Collaborator
Builds ready [b9b247b]
Page Load Metrics (1916 ± 647 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
darkwing
previously approved these changes
Mar 26, 2024
vthomas13
previously approved these changes
Mar 26, 2024
b9b247b to
e5cc7b7
Compare
darkwing
approved these changes
Mar 26, 2024
Collaborator
Builds ready [e5cc7b7]
Page Load Metrics (526 ± 423 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
vthomas13
approved these changes
Mar 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to add toast in the following scenarios:
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2281
Manual testing steps
Screenshots/Recordings
Before
NA
After
When a new account is connected
Screen.Recording.2024-03-21.at.4.59.06.PM.mov
When a single account is disconnected
Screen.Recording.2024-03-21.at.4.59.33.PM.mov
When all accounts are disconnected
Screen.Recording.2024-03-21.at.4.59.57.PM.mov
Pre-merge author checklist
Pre-merge reviewer checklist