Skip to content

feat: change in security settings - removing opensea provider and design changes#23546

Merged
jpuri merged 8 commits intodevelopfrom
security_settings
Mar 19, 2024
Merged

feat: change in security settings - removing opensea provider and design changes#23546
jpuri merged 8 commits intodevelopfrom
security_settings

Conversation

@jpuri
Copy link
Copy Markdown
Contributor

@jpuri jpuri commented Mar 18, 2024

Description

Removing opensea security provider from settings and change in UI / designs.

Related issues

Fixes: MetaMask/MetaMask-planning#2135

Manual testing steps

  1. Go to settings page in extension
  2. Find changes in security provider section

Screenshots/Recordings

Screenshot 2024-03-18 at 5 43 12 PM

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added team-confirmations-secure-ux-PR PRs from the confirmations team needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Mar 18, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 18, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.44%. Comparing base (a097040) to head (c59a150).
Report is 1 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #23546      +/-   ##
===========================================
- Coverage    68.44%   68.44%   -0.01%     
===========================================
  Files         1141     1141              
  Lines        43770    43758      -12     
  Branches     11729    11727       -2     
===========================================
- Hits         29958    29946      -12     
  Misses       13812    13812

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Mar 19, 2024

Builds ready [3413861]
Page Load Metrics (1172 ± 432 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint671871103316
domContentLoaded966332010
load5420691172900432
domInteractive966332010
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: -2.44 KiB (-0.03%)
  • common: -256 Bytes (-0.01%)

@jpuri jpuri marked this pull request as ready for review March 19, 2024 12:25
@jpuri jpuri requested a review from a team as a code owner March 19, 2024 12:25
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Mar 19, 2024

Builds ready [8038d04]
Page Load Metrics (995 ± 492 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint722641335426
domContentLoaded116531178
load5926509951025492
domInteractive116431178
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: -2.16 KiB (-0.03%)
  • common: -209 Bytes (-0.00%)

@jpuri jpuri merged commit b1c9060 into develop Mar 19, 2024
@jpuri jpuri deleted the security_settings branch March 19, 2024 14:56
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 19, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 19, 2024
@metamaskbot metamaskbot added the release-11.14.0 Issue or pull request that will be included in release 11.14.0 label Mar 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@pedronfigueiredo pedronfigueiredo pedronfigueiredo approved these changes

+1 more reviewer

@segun segun segun approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-11.14.0 Issue or pull request that will be included in release 11.14.0 team-confirmations-secure-ux-PR PRs from the confirmations team

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jpuri @metamaskbot @segun @pedronfigueiredo