Skip to content

Feat: add linea sepolia network#23459

Merged
DDDDDanica merged 18 commits intodevelopfrom
feat/add-linea-sepolia-network
Mar 26, 2024
Merged

Feat: add linea sepolia network#23459
DDDDDanica merged 18 commits intodevelopfrom
feat/add-linea-sepolia-network

Conversation

@VGau
Copy link
Copy Markdown
Contributor

@VGau VGau commented Mar 13, 2024

Description

  • A new Linea Sepolia network will be released soon. This PR adds support for the Linea Sepolia network in the MetaMask extension.
  • Deprecate Linea Goerli network

Related issues

Fixes:

Manual testing steps

For Linea Sepolia :

  • Select Linea Sepolia network
  • Send a transaction
  • Check the transaction result in the explorer
  • Make sure the Linea Sepolia network is display in the network settings page

For Linea Goerli deprecation :

  • Select Linea Goerli network
  • Check that Linea Goerli deprecation message is display at the bottom of the screen

Screenshots/Recordings

Before

After

FVCCV4m9oj.mp4

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@VGau VGau added needs-qa Label will automate into QA workspace team-linea Linea team labels Mar 13, 2024
@VGau VGau requested a review from a team as a code owner March 13, 2024 14:18
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 13, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@socket-security
Copy link
Copy Markdown

socket-security bot commented Mar 13, 2024 •
edited
Loading

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request

@VGau VGau requested review from a team as code owners March 15, 2024 19:09
@VGau VGau removed the needs-qa Label will automate into QA workspace label Mar 15, 2024
mcmire
mcmire previously approved these changes Mar 19, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me from a Shared Libraries perspective. We've already upgraded approval-controller, transaction-controller, and network-controller in a previous PR, so as long as we're okay with just sending transactions working then this PR makes sense to me.

DDDDDanica
DDDDDanica previously approved these changes Mar 25, 2024
View reviewed changes
@VGau VGau dismissed stale reviews from DDDDDanica and mcmire via 7ad0752 March 25, 2024 17:21
@MetaMask MetaMask deleted a comment from metamaskbot Mar 26, 2024
@VGau
Copy link
Copy Markdown
Contributor Author

VGau commented Mar 26, 2024

@metamaskbot update-policies

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Mar 26, 2024

Policy update failed. You can review the logs or retry the policy update here

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Mar 26, 2024

Policies updated

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Mar 26, 2024

Builds ready [3676898]
Page Load Metrics (687 ± 434 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint843551355828
domContentLoaded176836189
load612408687904434
domInteractive176836189
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 31 Bytes (0.00%)
  • ui: 1.27 KiB (0.02%)
  • common: 1.23 KiB (0.02%)

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 73.33333% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 69.28%. Comparing base (8b12ade) to head (3676898).

Files Patch % Lines
...network-screen/loading-network-screen.component.js 0.00% 2 Missing ⚠️
ui/helpers/constants/settings.js 33.33% 2 Missing ⚠️
ui/pages/routes/routes.component.js 0.00% 2 Missing ⚠️
ui/selectors/selectors.js 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #23459   +/-   ##
========================================
  Coverage    69.28%   69.28%           
========================================
  Files         1158     1158           
  Lines        44069    44096   +27     
  Branches     11758    11766    +8     
========================================
+ Hits         30531    30550   +19     
- Misses       13538    13546    +8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DDDDDanica DDDDDanica merged commit f3b8325 into develop Mar 26, 2024
@DDDDDanica DDDDDanica deleted the feat/add-linea-sepolia-network branch March 26, 2024 10:58
@github-actions github-actions bot locked and limited conversation to collaborators Mar 26, 2024
@metamaskbot metamaskbot added the release-11.15.0 Issue or pull request that will be included in release 11.15.0 label Mar 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sahar-fehri sahar-fehri sahar-fehri approved these changes

@DDDDDanica DDDDDanica DDDDDanica approved these changes

@mcmire mcmire mcmire left review comments

Assignees

No one assigned

Labels

release-11.15.0 Issue or pull request that will be included in release 11.15.0 team-linea Linea team

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@VGau @metamaskbot @mcmire @sahar-fehri @DDDDDanica