Skip to content

feat(23012): convert 2 level 19 files to ts#23445

Merged
DDDDDanica merged 3 commits intodevelopfrom
feature/23012
Mar 13, 2024
Merged

feat(23012): convert 2 level 19 files to ts#23445
DDDDDanica merged 3 commits intodevelopfrom
feature/23012

Conversation

@DDDDDanica
Copy link
Copy Markdown
Contributor

@DDDDDanica DDDDDanica commented Mar 13, 2024

Description

Reopen #23276 to be able to add changes, encountered weird issue of not being able to push new changes

In order to contribute to ts conversion of metamask-controller.js, we started the conversion of related files.
shared/modules/transaction.utils.ts and shared/notifications/index.ts will be 2 lower level files we included here.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@DDDDDanica DDDDDanica added the team-extension-platform Extension Platform team label Mar 13, 2024
@DDDDDanica DDDDDanica self-assigned this Mar 13, 2024
@DDDDDanica DDDDDanica requested a review from a team as a code owner March 13, 2024 01:42
@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@DDDDDanica DDDDDanica force-pushed the feature/23012 branch 4 times, most recently from b8e387a to 08e7ae5 Compare March 13, 2024 02:03
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [08e7ae5]
Page Load Metrics (1155 ± 451 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint763471436632
domContentLoaded13144373115
load6029451155940451
domInteractive12144373115
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -5 Bytes (-0.00%)
  • ui: 0 Bytes (0.00%)
  • common: -212 Bytes (-0.00%)

@DDDDDanica DDDDDanica added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 13, 2024
@DDDDDanica DDDDDanica merged commit 621f3c8 into develop Mar 13, 2024
@DDDDDanica DDDDDanica deleted the feature/23012 branch March 13, 2024 14:29
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 13, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2024
@metamaskbot metamaskbot added the release-11.14.0 Issue or pull request that will be included in release 11.14.0 label Mar 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-11.14.0 Issue or pull request that will be included in release 11.14.0 team-extension-platform Extension Platform team

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants