feat(23012): convert 2 level 19 files to ts#23445
Merged
DDDDDanica merged 3 commits intodevelopfrom Mar 13, 2024
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
13 tasks
b8e387a to
08e7ae5
Compare
Collaborator
Builds ready [08e7ae5]
Page Load Metrics (1155 ± 451 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
albertolive
approved these changes
Mar 13, 2024
NidhiKJha
approved these changes
Mar 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reopen #23276 to be able to add changes, encountered weird issue of not being able to push new changes
In order to contribute to ts conversion of metamask-controller.js, we started the conversion of related files.
shared/modules/transaction.utils.ts and shared/notifications/index.ts will be 2 lower level files we included here.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist