Skip to content

test: set snap-account-abstraction-keyring to a fixed version#23440

Merged
gantunesr merged 1 commit intodevelopfrom
test/aa-snap-version
Mar 13, 2024
Merged

test: set snap-account-abstraction-keyring to a fixed version#23440
gantunesr merged 1 commit intodevelopfrom
test/aa-snap-version

Conversation

@gantunesr
Copy link
Copy Markdown
Member

@gantunesr gantunesr commented Mar 12, 2024 •
edited
Loading

Description

Set the version of the snap-account-abstraction-keyring to 0.2.2 instead of pointing to the latest version. This change is required to avoid breaking the CI in case a new version of the snap is not compatible with the current state of the E2E tests.

Open in GitHub Codespaces

Related issues

No related issue

Manual testing steps

No manual test required.

Screenshots/Recordings

Not applicable

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@gantunesr gantunesr requested a review from a team as a code owner March 12, 2024 21:37
@gantunesr gantunesr added team-confirmations-system-deprecated DEPRECATED: please use "team-confirmations" instead team-accounts-framework Accounts team labels Mar 12, 2024
@gantunesr gantunesr self-assigned this Mar 12, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Mar 12, 2024

Builds ready [8149b25]
Page Load Metrics (1293 ± 376 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint842201313316
domContentLoaded1189412411
load7120021293784376
domInteractive1189412411
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.72%. Comparing base (6e397d0) to head (8149b25).

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #23440   +/-   ##
========================================
  Coverage    68.72%   68.72%           
========================================
  Files         1124     1124           
  Lines        43606    43606           
  Branches     11669    11669           
========================================
  Hits         29967    29967           
  Misses       13639    13639

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@suleyda01

This comment has been minimized.

Sign in to view
@gantunesr gantunesr merged commit 669022c into develop Mar 13, 2024
@gantunesr gantunesr deleted the test/aa-snap-version branch March 13, 2024 10:17
@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2024
@metamaskbot metamaskbot added the release-11.14.0 Issue or pull request that will be included in release 11.14.0 label Mar 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@HowardBraham HowardBraham HowardBraham approved these changes

@FrederikBolding FrederikBolding FrederikBolding approved these changes

@matthewwalsh0 matthewwalsh0 matthewwalsh0 approved these changes

@owencraston owencraston owencraston approved these changes

@montelaidev montelaidev montelaidev approved these changes

Assignees

@gantunesr gantunesr

Labels

release-11.14.0 Issue or pull request that will be included in release 11.14.0 team-accounts-framework Accounts team team-confirmations-system-deprecated DEPRECATED: please use "team-confirmations" instead

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@gantunesr @metamaskbot @suleyda01 @HowardBraham @FrederikBolding @matthewwalsh0 @owencraston @montelaidev