feat: add cross chain swaps link in extension#23437
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
Builds ready [ace446b]
Page Load Metrics (1162 ± 388 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
micaelae
previously approved these changes
Mar 12, 2024
66f61ab to
ace446b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #23437 +/- ##
========================================
Coverage 68.72% 68.73%
========================================
Files 1124 1124
Lines 43606 43618 +12
Branches 11669 11675 +6
========================================
+ Hits 29967 29977 +10
- Misses 13639 13641 +2 ☔ View full report in Codecov by Sentry. |
micaelae
previously approved these changes
Mar 12, 2024
Collaborator
Builds ready [ace446b]
Page Load Metrics (1081 ± 441 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
added 2 commits
March 12, 2024 18:28
Collaborator
Builds ready [2d52296]
Page Load Metrics (972 ± 385 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
micaelae
approved these changes
Mar 12, 2024
ejwessel
approved these changes
Mar 12, 2024
micaelae
reviewed
Mar 13, 2024
| onClick={() => { | ||
| const portfolioUrl = getPortfolioUrl( | ||
| 'bridge', | ||
| 'ext_bridge_button', |
Member
There was a problem hiding this comment.
I think we should change this to differentiate between these clicks and those from the overview page buttons
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As part of ongoing monetization efforts, Portfolio primitives are looking for opportunities to enable new revenue-generating flows. One area is the swaps page, where we can recommend users navigate to MetaMask Bridges if they wish to complete a cross-chain swap. Our hypothesis is that this will allow us to better target users that wish to complete both a swap and a bridge.
Related issues
METABRIDGE-846
Manual testing steps
ALLOWED_BRIDGE_CHAIN_IDS, or add a Swaps Testnet (chain ID 1337) to MetaMask to test this.Screenshots/Recordings
Before
After
After clicking the link in either state:
Pre-merge author checklist
Pre-merge reviewer checklist