Skip to content

fix: AvatarGroup usage in TokenList#23396

Merged
vthomas13 merged 1 commit intodevelopfrom
fix-avatar-group
Mar 8, 2024
Merged

fix: AvatarGroup usage in TokenList#23396
vthomas13 merged 1 commit intodevelopfrom
fix-avatar-group

Conversation

@vthomas13
Copy link
Copy Markdown
Contributor

@vthomas13 vthomas13 commented Mar 8, 2024 •
edited by github-actions bot
Loading

Description

Fixing a regression with AvatarGroup where the missing mapping for avatarValue was causing tokens in the AvatarGroup to not show images.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

image

After

image image

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@vthomas13 vthomas13 added needs-ux-ds-review team-core-extension-ux Core Extension UX team needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. labels Mar 8, 2024
@vthomas13 vthomas13 requested a review from a team as a code owner March 8, 2024 14:27
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 8, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@vthomas13 vthomas13 changed the title fix: Refactor AccountListItem to use mappedOrderedTokenList fix: AvatarGroup usage in TokenList Mar 8, 2024
@vthomas13 vthomas13 requested a review from frankvonhoven March 8, 2024 14:31
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Mar 8, 2024

Builds ready [1fff5db]
Page Load Metrics (1337 ± 347 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint732801505526
domContentLoaded1281382110
load5919811337722347
domInteractive1281382110
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 40 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 68.70%. Comparing base (6c810aa) to head (1fff5db).

Files Patch % Lines
.../multichain/account-list-item/account-list-item.js 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #23396      +/-   ##
===========================================
- Coverage    68.70%   68.70%   -0.00%     
===========================================
  Files         1120     1120              
  Lines        43509    43510       +1     
  Branches     11636    11636              
===========================================
  Hits         29891    29891              
- Misses       13618    13619       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vthomas13 vthomas13 merged commit eec736a into develop Mar 8, 2024
@vthomas13 vthomas13 deleted the fix-avatar-group branch March 8, 2024 15:05
@github-actions github-actions bot locked and limited conversation to collaborators Mar 8, 2024
@metamaskbot metamaskbot added the release-11.14.0 Issue or pull request that will be included in release 11.14.0 label Mar 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@NidhiKJha NidhiKJha NidhiKJha approved these changes

@jonybur jonybur Awaiting requested review from jonybur

@frankvonhoven frankvonhoven Awaiting requested review from frankvonhoven

+2 more reviewers

@darkwing darkwing darkwing approved these changes

@BZahory BZahory BZahory approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-11.14.0 Issue or pull request that will be included in release 11.14.0 team-core-extension-ux Core Extension UX team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vthomas13 @metamaskbot @darkwing @NidhiKJha @BZahory