Description

When using the per-dapp network selection feature flag, subscribe and filter requests are not respecting the per-dapp selection. This the main goal of this PR. Additionally, this PR correctly uses the persisted values for the feature flag. It also addresses an issue where changing the feature flag value would require dapps to be refreshed.

Related issues

Manual testing steps

note to test subscribe:

1. go to https://docs.metamask.io/wallet/reference/eth_subscribe/

2. open dev tools / console and add event listener: window.ethereum.on('message', ({data}) => console.log(parseInt(data.result.number, 16)));

3. hit execute on eth_subscribe

4. console should now start showing block updates

5. Basic Functionality Tests:
   - Verify that subscribing to different Ethereum events (like block headers, logs, or specific event types) works as expected.
   - Test filtering functionalities, ensuring that the filter correctly captures and displays events based on provided criteria.

6. Network-Specific Tests:
   - Test the subscribe and filter functionalities across different networks (mainnet, Ropsten, Kovan, etc.) to ensure consistent behavior.
   - Check for any network-specific issues or inconsistencies in the functioning of the subscribe and filter features.

7. Test with and without useRequestQueue Feature Flag:
   - Conduct tests with the useRequestQueue feature flag enabled and verify the functioning of the subscribe and filter features.
   - Repeat the tests with the feature flag disabled to ensure that the functionalities remain stable and consistent.

8. Repeat the above tests, but in a multi-dapp scenario

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've clearly explained what problem this PR is solving and how it is solved.
• I've linked related issues
• I've included manual testing steps
• I've included screenshots/recordings if applicable
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
• I’ve properly set the pull request status:
  • In case it's not yet "ready for review", I've set it to "draft".
  • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.