Skip to content

fix: enable Snaps home pages in stable#23383

Merged
FrederikBolding merged 2 commits intodevelopfrom
fb/enable-home-pages-in-stable
Mar 7, 2024
Merged

fix: enable Snaps home pages in stable#23383
FrederikBolding merged 2 commits intodevelopfrom
fb/enable-home-pages-in-stable

Conversation

@FrederikBolding
Copy link
Copy Markdown
Member

@FrederikBolding FrederikBolding commented Mar 7, 2024 •
edited by github-actions bot
Loading

Description

Enables Snaps home pages in stable. We thought we had already done this, but it turns out we forgot enable it.

Open in GitHub Codespaces

@FrederikBolding FrederikBolding added the team-snaps-platform-deprecated DEPRECATED: please use "team-core-platform" instead (or "team-new-networks" for Solana snap issues) label Mar 7, 2024
@FrederikBolding FrederikBolding requested review from a team as code owners March 7, 2024 21:27
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Mar 7, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.67%. Comparing base (65769f1) to head (001c80c).
Report is 1 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #23383   +/-   ##
========================================
  Coverage    68.67%   68.67%           
========================================
  Files         1106     1106           
  Lines        43353    43353           
  Branches     11590    11590           
========================================
  Hits         29771    29771           
  Misses       13582    13582

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FrederikBolding FrederikBolding merged commit 9ee8738 into develop Mar 7, 2024
@FrederikBolding FrederikBolding deleted the fb/enable-home-pages-in-stable branch March 7, 2024 21:55
@github-actions github-actions bot locked and limited conversation to collaborators Mar 7, 2024
@metamaskbot metamaskbot added the release-11.14.0 Issue or pull request that will be included in release 11.14.0 label Mar 7, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Mar 7, 2024

Builds ready [001c80c]
Page Load Metrics (816 ± 441 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint742471244421
domContentLoaded1074332010
load602689816919441
domInteractive1074322010
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: -40 Bytes (-0.00%)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Mrtenz Mrtenz Mrtenz approved these changes

@hmalik88 hmalik88 hmalik88 approved these changes

Assignees

No one assigned

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template release-11.14.0 Issue or pull request that will be included in release 11.14.0 team-snaps-platform-deprecated DEPRECATED: please use "team-core-platform" instead (or "team-new-networks" for Solana snap issues)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@FrederikBolding @metamaskbot @Mrtenz @hmalik88