Skip to content

feat: reveal and hide private keys #23371

Merged
georgewrmarshall merged 3 commits intodevelopfrom
feat/20719-toggle-private-key-input
Mar 7, 2024
Merged

feat: reveal and hide private keys #23371
georgewrmarshall merged 3 commits intodevelopfrom
feat/20719-toggle-private-key-input

Conversation

@dawnseeker8
Copy link
Copy Markdown
Contributor

@dawnseeker8 dawnseeker8 commented Mar 7, 2024 •
edited
Loading

Description

Adds a show/hide element which toggles whether the private key input value is visible or not.

Note

This is the same PR as #20719 from external repo, due to ci/circleci: prep-deps always failed for external contributor. I create this PR internally as workaround to run CI.

Open in GitHub Codespaces

Related issues

Fixes: #20630

Manual testing steps

  1. Click the accounts menu dropdown
  2. Select Import account
  3. Ensure the private key input defaults to hidden
  4. Ensure the show/hide toggle switches between input visibility appropriately
  5. Ensure that the private key import functionality is otherwise unchanged

Screenshots/Recordings

Before

before1080.mov

After

after1080.mov

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@dawnseeker8 dawnseeker8 requested a review from a team as a code owner March 7, 2024 14:21
@dawnseeker8 dawnseeker8 self-assigned this Mar 7, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 7, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@dawnseeker8 dawnseeker8 added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-accounts-framework Accounts team labels Mar 7, 2024
@dawnseeker8 dawnseeker8 mentioned this pull request Mar 7, 2024
Closed
8 tasks
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Mar 7, 2024

Builds ready [43cd92e]
Page Load Metrics (747 ± 394 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint712381164120
domContentLoaded10169333618
load572113747821394
domInteractive10169333618
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 197 Bytes (0.00%)
  • common: 383 Bytes (0.01%)

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 68.66%. Comparing base (3423aab) to head (43cd92e).
Report is 1 commits behind head on develop.

Files Patch % Lines
...omponents/multichain/import-account/private-key.js 66.67% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #23371      +/-   ##
===========================================
- Coverage    68.66%   68.66%   -0.00%     
===========================================
  Files         1105     1105              
  Lines        43330    43333       +3     
  Branches     11581    11582       +1     
===========================================
+ Hits         29749    29751       +2     
- Misses       13581    13582       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gantunesr gantunesr changed the title feat: 20719 create a toggle private field in private-key.js feat: reveal and hide private keys Mar 7, 2024
@georgewrmarshall georgewrmarshall merged commit 320f5bf into develop Mar 7, 2024
@georgewrmarshall georgewrmarshall deleted the feat/20719-toggle-private-key-input branch March 7, 2024 22:53
@github-actions github-actions bot locked and limited conversation to collaborators Mar 7, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 7, 2024
@metamaskbot metamaskbot added the release-11.14.0 Issue or pull request that will be included in release 11.14.0 label Mar 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@georgewrmarshall georgewrmarshall georgewrmarshall approved these changes

+1 more reviewer

@garrettbear garrettbear garrettbear approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dawnseeker8 dawnseeker8

Labels

release-11.14.0 Issue or pull request that will be included in release 11.14.0 team-accounts-framework Accounts team

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow user to toggle obfuscation on input of private key

4 participants

@dawnseeker8 @metamaskbot @georgewrmarshall @garrettbear