fix: use gap for Snap UI spacing#23369
Merged
FrederikBolding merged 3 commits intodevelopfrom Mar 7, 2024
Merged
Conversation
GuillaumeRx
approved these changes
Mar 7, 2024
hmalik88
approved these changes
Mar 7, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #23369 +/- ##
========================================
Coverage 68.72% 68.72%
========================================
Files 1105 1105
Lines 43250 43250
Branches 11562 11562
========================================
Hits 29720 29720
Misses 13530 13530 ☔ View full report in Codecov by Sentry. |
Collaborator
Builds ready [abdc876]
Page Load Metrics (1126 ± 414 ms)
Bundle size diffs
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the Snap UI renderer to use
gapfor spacing between elements instead of margin. This is more effective than our previous attempts at normalizing spacing with nested panels etc. The new standard is8pxof gap between everything except panels at the root level which has16pxof gap (at the request of @eriknson). This PR removes all the margins for the existing components.