Skip to content

feat: Add MetaMask Portfolio What's New notification#23359

Merged
vthomas13 merged 2 commits intodevelopfrom
2181-whats-new-portfolio
Mar 12, 2024
Merged

feat: Add MetaMask Portfolio What's New notification#23359
vthomas13 merged 2 commits intodevelopfrom
2181-whats-new-portfolio

Conversation

@vthomas13
Copy link
Copy Markdown
Contributor

@vthomas13 vthomas13 commented Mar 6, 2024 •
edited
Loading

Description

Adding a what's new notification for Portfolio

Open in GitHub Codespaces

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2181

Manual testing steps

  1. Open Extension
  2. Confirm that the Portfolio What's New appears
  3. Confirm that upon clicking the CTA, you are sent to the Portfolio website
  4. Confirm that on dismissal, the notification does not show up again

Screenshots/Recordings

Before

After

image

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@vthomas13 vthomas13 requested a review from a team as a code owner March 6, 2024 23:12
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 6, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 6, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 68.71%. Comparing base (1803b49) to head (7615ea9).
Report is 1 commits behind head on develop.

Files Patch % Lines
.../components/app/whats-new-popup/whats-new-popup.js 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #23359      +/-   ##
===========================================
- Coverage    68.72%   68.71%   -0.00%     
===========================================
  Files         1122     1122              
  Lines        43577    43581       +4     
  Branches     11661    11661              
===========================================
+ Hits         29945    29946       +1     
- Misses       13632    13635       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Mar 6, 2024

Builds ready [c1959b6]
Page Load Metrics (721 ± 398 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint892601374522
domContentLoaded10101402613
load762114721828398
domInteractive10101402613
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 233 Bytes (0.00%)
  • common: 1.06 KiB (0.02%)

@vthomas13 vthomas13 added needs-ux-ds-review team-core-extension-ux Core Extension UX team needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. labels Mar 7, 2024
@vthomas13 vthomas13 self-assigned this Mar 7, 2024
@vthomas13 vthomas13 force-pushed the 2181-whats-new-portfolio branch from c1959b6 to 809bc5b Compare March 7, 2024 16:05
@vthomas13 vthomas13 changed the title fetAdd MetaMask Portfolio What's New notification feat: Add MetaMask Portfolio What's New notification Mar 7, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Mar 7, 2024

Builds ready [809bc5b]
Page Load Metrics (1240 ± 414 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint693541386431
domContentLoaded1184392412
load5222361240862414
domInteractive1184392412
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 233 Bytes (0.00%)
  • common: 1.06 KiB (0.02%)

darkwing
darkwing approved these changes Mar 7, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@darkwing darkwing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! We should bookmark this as a prime example of how to create a quality What's New PR!

@vthomas13 vthomas13 force-pushed the 2181-whats-new-portfolio branch from 809bc5b to 7615ea9 Compare March 12, 2024 13:47
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Mar 12, 2024

Builds ready [7615ea9]
Page Load Metrics (1211 ± 401 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint772401294421
domContentLoaded1097332412
load6319871211836401
domInteractive1097332412
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 233 Bytes (0.00%)
  • common: 1.06 KiB (0.02%)

@vthomas13 vthomas13 merged commit 7d26f8c into develop Mar 12, 2024
@vthomas13 vthomas13 deleted the 2181-whats-new-portfolio branch March 12, 2024 15:44
@github-actions github-actions bot locked and limited conversation to collaborators Mar 12, 2024
@metamaskbot metamaskbot added the release-11.14.0 Issue or pull request that will be included in release 11.14.0 label Mar 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@NidhiKJha NidhiKJha NidhiKJha approved these changes

@jonybur jonybur Awaiting requested review from jonybur

+1 more reviewer

@darkwing darkwing darkwing approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@vthomas13 vthomas13

Labels

needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-11.14.0 Issue or pull request that will be included in release 11.14.0 team-core-extension-ux Core Extension UX team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vthomas13 @metamaskbot @darkwing @NidhiKJha