Skip to content

Adding info row component for typed sign data#23315

Merged
jpuri merged 1 commit intodevelopfrom
typed_sign_data_info_row
Mar 12, 2024
Merged

Adding info row component for typed sign data#23315
jpuri merged 1 commit intodevelopfrom
typed_sign_data_info_row

Conversation

@jpuri
Copy link
Copy Markdown
Contributor

@jpuri jpuri commented Mar 5, 2024

Description

Adding value component for TypedSignData

Related issues

Fixes: #21284

Manual testing steps

NA

Screenshots/Recordings

Screenshot 2024-03-05 at 5 28 18 PM

Before

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added team-confirmations-secure-ux-PR PRs from the confirmations team needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Mar 5, 2024
@jpuri jpuri requested a review from a team as a code owner March 5, 2024 13:12
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 5, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Ramyromel
Copy link
Copy Markdown

Ramyromel commented Mar 5, 2024

Help me please 🥺

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Mar 5, 2024

Builds ready [2519b8e]
Page Load Metrics (1271 ± 369 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint692331484321
domContentLoaded1185472211
load5621671271768369
domInteractive1185472211
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 1.21 KiB (0.02%)
  • common: 460 Bytes (0.01%)

Base automatically changed from personal_sign_message to develop March 6, 2024 15:04
@jpuri jpuri force-pushed the typed_sign_data_info_row branch from b153ac8 to 174e9a0 Compare March 6, 2024 15:08
@jpuri jpuri force-pushed the typed_sign_data_info_row branch from 174e9a0 to 1056f8c Compare March 6, 2024 16:25
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.73%. Comparing base (75a91b0) to head (1056f8c).
Report is 2 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #23315      +/-   ##
===========================================
+ Coverage    68.71%   68.73%   +0.01%     
===========================================
  Files         1105     1107       +2     
  Lines        43248    43268      +20     
  Branches     11561    11567       +6     
===========================================
+ Hits         29717    29737      +20     
  Misses       13531    13531

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Mar 6, 2024

Builds ready [1056f8c]
Page Load Metrics (1012 ± 502 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint692041244120
domContentLoaded116629157
load56281010121046502
domInteractive116629157
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 37 Bytes (0.00%)

@jpuri jpuri merged commit 62a21bc into develop Mar 12, 2024
@jpuri jpuri deleted the typed_sign_data_info_row branch March 12, 2024 10:37
@github-actions github-actions bot locked and limited conversation to collaborators Mar 12, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 12, 2024
@metamaskbot metamaskbot added the release-11.14.0 Issue or pull request that will be included in release 11.14.0 label Mar 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@pedronfigueiredo pedronfigueiredo pedronfigueiredo approved these changes

+1 more reviewer

@blackdevelopa blackdevelopa blackdevelopa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-11.14.0 Issue or pull request that will be included in release 11.14.0 team-confirmations-secure-ux-PR PRs from the confirmations team

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create component to display nested message data for signature request typed data

5 participants

@jpuri @Ramyromel @metamaskbot @pedronfigueiredo @blackdevelopa