build: remove static copy of react-responsive-carousel styles as it is no longer used statically#23278
Merged
davidmurdoch merged 4 commits intodevelopfrom Mar 7, 2024
Merged
Conversation
… is no longer used statically fixes #23094
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
Builds ready [ffe9c11]
Page Load Metrics (1360 ± 357 ms)
Bundle size diffs
|
Collaborator
Builds ready [a9bc7b9]
Page Load Metrics (1190 ± 399 ms)
Bundle size diffs
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #23278 +/- ##
========================================
Coverage 68.72% 68.72%
========================================
Files 1105 1105
Lines 43250 43250
Branches 11562 11562
========================================
Hits 29720 29720
Misses 13530 13530 ☔ View full report in Codecov by Sentry. |
Collaborator
Builds ready [380aa09]
Page Load Metrics (1278 ± 377 ms)
Bundle size diffs
|
legobeat
approved these changes
Mar 7, 2024
Collaborator
Builds ready [afc4f2c]
Page Load Metrics (1212 ± 433 ms)
Bundle size diffs
|
danjm
approved these changes
Mar 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change https://github.com/MetaMask/metamask-extension/pull/22531/files#diff-89ed0c4bbc62cc2f988334cb1572c5667d03bbf48b44c89f1d8f9e685bd2c257R6 allows for this PR.
Fixes #23094