Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
salimtb
previously approved these changes
Mar 1, 2024
13 tasks
…extension into brian/asset-picker-qa
… brian/asset-picker-qa
… brian/asset-picker-qa
Collaborator
Builds ready [9460f33]
Page Load Metrics (936 ± 409 ms)
Bundle size diffs
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #23264 +/- ##
===========================================
+ Coverage 68.61% 68.62% +0.01%
===========================================
Files 1101 1101
Lines 43206 43214 +8
Branches 11568 11573 +5
===========================================
+ Hits 29645 29654 +9
+ Misses 13561 13560 -1 ☔ View full report in Codecov by Sentry. |
Collaborator
Builds ready [48b2cb4]
Page Load Metrics (1428 ± 278 ms)
Bundle size diffs
|
sahar-fehri
approved these changes
Mar 6, 2024
salimtb
approved these changes
Mar 6, 2024
DDDDDanica
approved these changes
Mar 7, 2024
Comment on lines
+39
to
+49
| if (asset.type === AssetType.native) { | ||
| image = nativeCurrencyImage; | ||
| } else if (asset.type === AssetType.token) { | ||
| image = | ||
| asset.details?.image ?? | ||
| // eslint-disable-next-line @typescript-eslint/ban-ts-comment | ||
| // @ts-ignore: type 'string' can't be used to index type '{}' | ||
| tokenList?.[asset.details?.address?.toLowerCase()]?.iconUrl; | ||
| } else if (asset.type === AssetType.NFT) { | ||
| image = getAssetImageURL(asset.details?.image, ipfsGateway); | ||
| } |
Contributor
There was a problem hiding this comment.
Nit: Can we use switch to make it easier to read and modify / add more conditions in the future ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes some things with the asset picker.
Vertical padding was increased in 4a930f9 to support the NFT case, but this made native + erc20 too tall.
before:
after:
original figma design:
before:
after:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist