Skip to content

chore: Bump @metamask/transaction-controller to 25.1.0 (along with related packages)#23252

Merged
mcmire merged 27 commits intodevelopfrom
upgrade-to-tc-bc-v2
Mar 18, 2024
Merged

chore: Bump @metamask/transaction-controller to 25.1.0 (along with related packages)#23252
mcmire merged 27 commits intodevelopfrom
upgrade-to-tc-bc-v2

Conversation

@mcmire
Copy link
Copy Markdown
Contributor

@mcmire mcmire commented Feb 29, 2024 •
edited
Loading

Description

This PR upgrades @metamask/transaction-controller from 23.1.0 to 25.1.0. This version includes several major changes, but the one that is most relevant for this PR is that TransactionController now inherits from BaseController v2. For more, see the changelog.

In order to satisfy peer dependency constraints, the following packages also needed to be bumped. There aren't any functional changes to these packages:

  • @metamask/approval-controller 5.1.0 -> 6.0.0 (view changelog)
  • @metamask/gas-fee-controller 13.0.0 -> 14.0.0 (view changelog)
  • @metamask/network-controller 17.2.0 -> 18.0.0 (view changelog)
  • @metamask/user-operation-controller 4.0.0 -> 6.0.0 (view changelog)
  • @babel/runtime 7.23.2 -> 7.24.0 (the patch file has also been regenerated)

Open in GitHub Codespaces

Related issues

PR that upgraded TransactionController to BaseController v2: MetaMask/core#3758

Manual testing steps

We'll want to verify that features related to transactions still work. Sending a transaction, seeing it confirmed, etc.

Screenshots/Recordings

(No screenshots to show)

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 29, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@mcmire mcmire changed the title WIP - Upgrade to TransactionController BaseController v2 chore: WIP - Upgrade to TransactionController BaseController v2 Feb 29, 2024
@mcmire mcmire force-pushed the upgrade-to-tc-bc-v2 branch from 39b22e1 to 20240ce Compare February 29, 2024 21:31
@mcmire
Copy link
Copy Markdown
Contributor Author

mcmire commented Mar 6, 2024

@metamaskbot update-policies

@socket-security
Copy link
Copy Markdown

socket-security bot commented Mar 6, 2024 •
edited
Loading

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Mar 6, 2024

Policies updated

@mcmire
Copy link
Copy Markdown
Contributor Author

mcmire commented Mar 6, 2024

@metamaskbot update-policies

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Mar 6, 2024

Policies updated

matthewwalsh0
matthewwalsh0 reviewed Mar 8, 2024
View reviewed changes
@mcmire
Copy link
Copy Markdown
Contributor Author

mcmire commented Mar 14, 2024

@metamaskbot update-policies

@mcmire mcmire changed the title Bump @metamask/transaction-controller to 25.0.0 (along with related packages) chore: Bump @metamask/transaction-controller to 25.0.0 (along with related packages) Mar 14, 2024
@mcmire mcmire changed the title chore: Bump @metamask/transaction-controller to 25.0.0 (along with related packages) chore: Bump @metamask/transaction-controller to 25.1.0 (along with related packages) Mar 14, 2024
@mcmire mcmire marked this pull request as ready for review March 14, 2024 21:02
@mcmire mcmire requested review from a team as code owners March 14, 2024 21:02
@mcmire
Copy link
Copy Markdown
Contributor Author

mcmire commented Mar 14, 2024

Judging by recent builds, the e2e failures seem like known flaky tests and therefore seem unrelated to the package bumps.

matthewwalsh0
matthewwalsh0 previously approved these changes Mar 15, 2024
View reviewed changes
OGPoyraz
OGPoyraz previously approved these changes Mar 18, 2024
View reviewed changes
@socket-security
Copy link
Copy Markdown

socket-security bot commented Mar 18, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/approval-controller@6.0.1 Transitive: environment, network +24 5.32 MB metamaskbot
npm/@metamask/gas-fee-controller@14.0.1 Transitive: environment, filesystem, network +72 13.7 MB metamaskbot
npm/@metamask/network-controller@18.0.1 environment Transitive: filesystem, network +68 13 MB metamaskbot
npm/@metamask/transaction-controller@25.1.0 Transitive: environment, filesystem, network +127 26.4 MB metamaskbot
npm/@metamask/user-operation-controller@6.0.1 network Transitive: environment, eval, filesystem +210 36.4 MB metamaskbot
npm/regenerator-runtime@0.14.0 None 0 27.8 kB benjamn

🚮 Removed packages: npm/@metamask/gas-fee-controller@13.0.2, npm/@metamask/transaction-controller@23.1.0, npm/@metamask/user-operation-controller@4.0.0, npm/@types/ms@0.7.34, npm/apg-js@4.3.0, npm/regenerator-runtime@0.14.1

View full report↗︎

@matthewwalsh0
Copy link
Copy Markdown
Member

matthewwalsh0 commented Mar 18, 2024

@metamaskbot update-policies

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Mar 18, 2024

Policies updated

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Mar 18, 2024

Builds ready [a46c68c]
Page Load Metrics (1305 ± 534 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint731981293316
domContentLoaded97134189
load59275513051112534
domInteractive97134189
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 194.74 KiB (5.41%)
  • ui: -12 Bytes (-0.00%)
  • common: 146.28 KiB (3.10%)

@mcmire mcmire merged commit 0de97df into develop Mar 18, 2024
@mcmire mcmire deleted the upgrade-to-tc-bc-v2 branch March 18, 2024 21:48
@github-actions github-actions bot locked and limited conversation to collaborators Mar 18, 2024
@metamaskbot metamaskbot added the release-11.14.0 Issue or pull request that will be included in release 11.14.0 label Mar 26, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Mar 26, 2024

No release label on PR. Adding release label release-11.14.0 on PR, as PR was added to branch 11.14.0 when release was cut.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@matthewwalsh0 matthewwalsh0 matthewwalsh0 approved these changes

@OGPoyraz OGPoyraz OGPoyraz left review comments

+1 more reviewer

@legobeat legobeat legobeat approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-11.14.0 Issue or pull request that will be included in release 11.14.0

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mcmire @metamaskbot @matthewwalsh0 @OGPoyraz @legobeat