Skip to content

fix: Fix broken Multichain send jest tests#23249

Merged
OGPoyraz merged 2 commits intodevelopfrom
fix-send-jest
Mar 1, 2024
Merged

fix: Fix broken Multichain send jest tests#23249
OGPoyraz merged 2 commits intodevelopfrom
fix-send-jest

Conversation

@darkwing
Copy link
Copy Markdown
Contributor

@darkwing darkwing commented Feb 29, 2024 •
edited by github-actions bot
Loading

Description

Fixes broken Jest tests on develop. Unsure to me what the root cause of this was, but obviously permissionHistory was missing.

Open in GitHub Codespaces

Related issues

N/A

Manual testing steps

Run jest.

Screenshots/Recordings

Before

N/A

After

N/A

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@darkwing darkwing requested a review from a team as a code owner February 29, 2024 18:34
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 29, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@darkwing darkwing changed the title Fix borken Multichain send jest tests Fix broken Multichain send jest tests Feb 29, 2024
@darkwing darkwing added the team-core-extension-ux Core Extension UX team label Feb 29, 2024
@darkwing darkwing changed the title Fix broken Multichain send jest tests fix: Fix broken Multichain send jest tests Feb 29, 2024
@jiexi
Copy link
Copy Markdown
Member

jiexi commented Feb 29, 2024

Odd, this is still broken for me when i pull your branch down locally and run yarn jest ui/components/multichain/pages/send/components/recipient.test.tsx

@darkwing darkwing force-pushed the fix-send-jest branch 2 times, most recently from 5c836e4 to f9e31cd Compare February 29, 2024 20:03
@darkwing darkwing added the needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. label Feb 29, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Feb 29, 2024

Builds ready [f9e31cd]
Page Load Metrics (1324 ± 402 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint671911193416
domContentLoaded97433199
load5425261324838402
domInteractive97333199
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

davidmurdoch
davidmurdoch reviewed Feb 29, 2024
View reviewed changes
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Feb 29, 2024

Builds ready [f09a3d1]
Page Load Metrics (1506 ± 292 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint822381324220
domContentLoaded118131199
load7719631506607292
domInteractive118131199
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@mcmire mcmire mentioned this pull request Mar 1, 2024
Merged
13 tasks
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Mar 1, 2024

Builds ready [fbbcb2d]
Page Load Metrics (1390 ± 321 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint701891312512
domContentLoaded116838199
load6521971390668321
domInteractive116838199
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@OGPoyraz OGPoyraz merged commit d77cf02 into develop Mar 1, 2024
@OGPoyraz OGPoyraz deleted the fix-send-jest branch March 1, 2024 12:34
@github-actions github-actions bot locked and limited conversation to collaborators Mar 1, 2024
@metamaskbot metamaskbot added the release-11.13.0 Issue or pull request that will be included in release 11.13.0 label Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@davidmurdoch davidmurdoch davidmurdoch approved these changes

@pedronfigueiredo pedronfigueiredo pedronfigueiredo approved these changes

@salimtb salimtb salimtb approved these changes

Assignees

No one assigned

Labels

needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-11.13.0 Issue or pull request that will be included in release 11.13.0 team-core-extension-ux Core Extension UX team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@darkwing @jiexi @metamaskbot @davidmurdoch @pedronfigueiredo @salimtb @OGPoyraz