Skip to content

fix(deps): web3-stream-provider@^4.0.0->^5.0.0#23216

Merged
legobeat merged 1 commit intoMetaMask:developfrom
legobeat:deps-web3-stream-provider
Apr 23, 2024
Merged

fix(deps): web3-stream-provider@^4.0.0->^5.0.0#23216
legobeat merged 1 commit intoMetaMask:developfrom
legobeat:deps-web3-stream-provider

Conversation

@legobeat
Copy link
Copy Markdown
Contributor

@legobeat legobeat commented Feb 28, 2024 •
edited
Loading

Description

This updates the version of readable-stream used by the StreamProvider from 2.3.8 to 3.6.2 to match that of its supplied connection stream (which it gets via @metamask/object-multiplex)

Open in GitHub Codespaces

Related issues

Blocking

Manual testing steps

N/A

Screenshots/Recordings

Before

N/A

After

N/A

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 28, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@legobeat legobeat added dependencies Pull requests that update a dependency file team-application-security Application security team labels Feb 28, 2024
@metamaskbot metamaskbot added INVALID-PR-TEMPLATE PR's body doesn't match template and removed INVALID-PR-TEMPLATE PR's body doesn't match template labels Feb 28, 2024
@legobeat legobeat marked this pull request as ready for review February 28, 2024 01:23
@legobeat legobeat requested a review from a team as a code owner February 28, 2024 01:23
@legobeat legobeat force-pushed the deps-web3-stream-provider branch from 66c2c2d to c626375 Compare February 28, 2024 01:23
@legobeat legobeat requested review from a team as code owners February 28, 2024 01:23
@socket-security
Copy link
Copy Markdown

socket-security bot commented Feb 28, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/web3-stream-provider@5.0.0 None 0 4.92 kB lgbot

🚮 Removed packages: npm/web3-stream-provider@4.0.1

View full report↗︎

@legobeat legobeat changed the title fix(deps): web3-stream-provider@4.0.0->5.0.0 fix(deps): web3-stream-provider@^4.0.0->^5.0.0 Feb 28, 2024
@legobeat legobeat force-pushed the deps-web3-stream-provider branch 2 times, most recently from 993eeb6 to 901ab7d Compare March 5, 2024 03:16
@legobeat legobeat force-pushed the deps-web3-stream-provider branch from 901ab7d to e65c662 Compare March 5, 2024 22:49
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.72%. Comparing base (62a21bc) to head (81ce393).

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #23216      +/-   ##
===========================================
- Coverage    68.72%   68.72%   -0.00%     
===========================================
  Files         1122     1122              
  Lines        43577    43577              
  Branches     11661    11661              
===========================================
- Hits         29945    29944       -1     
- Misses       13632    13633       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@legobeat legobeat force-pushed the deps-web3-stream-provider branch 6 times, most recently from d12541e to 3bd733a Compare March 11, 2024 01:06
@legobeat legobeat mentioned this pull request Mar 11, 2024
Merged
18 tasks
@legobeat legobeat force-pushed the deps-web3-stream-provider branch 5 times, most recently from c012d97 to 3cf1364 Compare March 14, 2024 10:25
@legobeat legobeat force-pushed the deps-web3-stream-provider branch 2 times, most recently from 4f79580 to 10122d1 Compare March 20, 2024 23:41
@legobeat legobeat force-pushed the deps-web3-stream-provider branch 3 times, most recently from 9ad09f0 to caaaa5f Compare March 27, 2024 23:45
@legobeat legobeat force-pushed the deps-web3-stream-provider branch 2 times, most recently from 4e11a0b to 721b2a7 Compare April 15, 2024 21:50
@socket-security
Copy link
Copy Markdown

socket-security bot commented Apr 15, 2024 •
edited
Loading

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@legobeat
Copy link
Copy Markdown
Contributor Author

legobeat commented Apr 15, 2024 

@SocketSecurity ignore npm/bufferutil@4.0.8

native code ok; actually unrelated

@legobeat legobeat requested a review from a team April 15, 2024 21:54
@legobeat legobeat force-pushed the deps-web3-stream-provider branch 3 times, most recently from a9b132b to b7deddc Compare April 19, 2024 20:41
@legobeat legobeat requested a review from mcmire April 19, 2024 20:41
@legobeat legobeat force-pushed the deps-web3-stream-provider branch 3 times, most recently from e33fb03 to 4a7fc24 Compare April 22, 2024 10:49
@legobeat legobeat requested a review from jiexi April 22, 2024 10:53
@legobeat legobeat force-pushed the deps-web3-stream-provider branch from 4a7fc24 to 2712eb9 Compare April 22, 2024 10:53
@legobeat legobeat mentioned this pull request Apr 23, 2024
Closed
7 tasks
@legobeat legobeat force-pushed the deps-web3-stream-provider branch from b437b5d to f2eeb9a Compare April 23, 2024 09:22
@legobeat legobeat force-pushed the deps-web3-stream-provider branch from f2eeb9a to 1ff88e6 Compare April 23, 2024 10:40
@legobeat legobeat merged commit bf946dc into MetaMask:develop Apr 23, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Apr 23, 2024
@legobeat legobeat deleted the deps-web3-stream-provider branch April 23, 2024 12:44
@metamaskbot metamaskbot added the release-11.16.0 Issue or pull request that will be included in release 11.16.0 label Apr 25, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Apr 25, 2024

No release label on PR. Adding release label release-11.16.0 on PR, as PR was added to branch 11.16.0 when release was cut.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jiexi jiexi jiexi approved these changes

@kumavis kumavis Awaiting requested review from kumavis

@FrederikBolding FrederikBolding Awaiting requested review from FrederikBolding

@mcmire mcmire Awaiting requested review from mcmire

+1 more reviewer

@brad-decker brad-decker brad-decker approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file release-11.16.0 Issue or pull request that will be included in release 11.16.0 team-application-security Application security team

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@legobeat @metamaskbot @jiexi @brad-decker