Skip to content

fix: missing network images#23140

Merged
bergeron merged 2 commits intodevelopfrom
brian/network-images-missing
Feb 23, 2024
Merged

fix: missing network images#23140
bergeron merged 2 commits intodevelopfrom
brian/network-images-missing

Conversation

@bergeron
Copy link
Copy Markdown
Contributor

@bergeron bergeron commented Feb 22, 2024 •
edited
Loading

Description

Fixes an issue where the image files for some networks were not present in the filesystem, causing metamask to crash when trying to load them. The affected chains were:

0x288 ./images/endurance-smart-chain.png
0x4d2 ./images/setp.svg
0x6a ./images/velas.svg
0x133e40 ./images/zkatana.svg

Open in GitHub Codespaces

Related issues

Fixes: #23084

Manual testing steps

Add any of the 4 affected chains to metamask, and visit the settings -> networks page. should not crash.

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@bergeron bergeron requested a review from a team as a code owner February 22, 2024 23:32
@bergeron bergeron changed the title fix missing network images fix: missing network images Feb 22, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 22, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Feb 23, 2024

Builds ready [f2dd396]
Page Load Metrics (1797 ± 55 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1182871774622
domContentLoaded118831199
load15882053179711655
domInteractive118831199
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 8 Bytes (0.00%)

danjm
danjm approved these changes Feb 23, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@danjm danjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bergeron bergeron merged commit bb634d5 into develop Feb 23, 2024
@bergeron bergeron deleted the brian/network-images-missing branch February 23, 2024 14:41
@github-actions github-actions bot locked and limited conversation to collaborators Feb 23, 2024
@metamaskbot metamaskbot added release-11.13.0 Issue or pull request that will be included in release 11.13.0 release-11.10.1 Issue or pull request that will be included in release 11.10.1 and removed release-11.13.0 Issue or pull request that will be included in release 11.13.0 labels Feb 23, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Feb 27, 2024

Missing release label release-11.10.1 on PR. Adding release label release-11.10.1 on PR and removing other release labels(release-11.13.0), as PR was cherry-picked in branch 11.10.1.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sahar-fehri sahar-fehri sahar-fehri approved these changes

@darkwing darkwing Awaiting requested review from darkwing

@salimtb salimtb Awaiting requested review from salimtb

+1 more reviewer

@danjm danjm danjm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-11.10.1 Issue or pull request that will be included in release 11.10.1 team-assets

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Can't access networks settings MetaMask encountered an error

4 participants

@bergeron @metamaskbot @danjm @sahar-fehri