Skip to content

Cherry-pick PR #23092 to v11.11.0#23131

Merged
dbrans merged 5 commits intoVersion-v11.11.0from
v11.11.0-cherry-pick-dbrans
Feb 26, 2024
Merged

Cherry-pick PR #23092 to v11.11.0#23131
dbrans merged 5 commits intoVersion-v11.11.0from
v11.11.0-cherry-pick-dbrans

Conversation

@dbrans
Copy link
Copy Markdown
Contributor

@dbrans dbrans commented Feb 22, 2024

Description

Cherry-pick PR #23092 to v11.11.0

There were no merge conflicts when picking these commits. However, additional lint fixes were required in this branch because linting is not working properly in develop.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@dbrans dbrans marked this pull request as ready for review February 22, 2024 22:16
@dbrans dbrans requested a review from a team as a code owner February 22, 2024 22:16
@gauthierpetetin gauthierpetetin added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 23, 2024
@dbrans dbrans merged commit b5d1949 into Version-v11.11.0 Feb 26, 2024
@dbrans dbrans deleted the v11.11.0-cherry-pick-dbrans branch February 26, 2024 21:10
@github-actions github-actions bot locked and limited conversation to collaborators Feb 26, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 26, 2024
@metamaskbot metamaskbot added the release-11.11.0 Issue or pull request that will be included in release 11.11.0 label Feb 26, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

No release label on PR. Adding release label release-11.11.0 on PR, as PR was cherry-picked in branch 11.11.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-11.11.0 Issue or pull request that will be included in release 11.11.0

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants