Skip to content

docs: add approval flows and result pages to confirmations documentation#23111

Merged
matthewwalsh0 merged 3 commits intodevelopfrom
doc/confirmations-approval-flows-result-pages
Mar 13, 2024
Merged

docs: add approval flows and result pages to confirmations documentation#23111
matthewwalsh0 merged 3 commits intodevelopfrom
doc/confirmations-approval-flows-result-pages

Conversation

@matthewwalsh0
Copy link
Copy Markdown
Member

@matthewwalsh0 matthewwalsh0 commented Feb 22, 2024 •
edited
Loading

Description

Update the confirmations documentation to include all related features such as Approval Flows and Result Pages.

Open in GitHub Codespaces

Related issues

Fixes: #2132

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@matthewwalsh0 matthewwalsh0 added the team-confirmations-system-deprecated DEPRECATED: please use "team-confirmations" instead label Feb 28, 2024
@matthewwalsh0 matthewwalsh0 marked this pull request as ready for review February 28, 2024 16:48
@matthewwalsh0 matthewwalsh0 requested a review from a team as a code owner February 28, 2024 16:48
@matthewwalsh0 matthewwalsh0 changed the title doc: add approval flows and result pages to confirmations documentation docs: add approval flows and result pages to confirmations documentation Feb 28, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Feb 28, 2024

Builds ready [df32700]
Page Load Metrics (938 ± 412 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint652311294723
domContentLoaded1084342110
load511908938859412
domInteractive1084342110
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.60%. Comparing base (02cbc94) to head (df32700).
Report is 1 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #23111   +/-   ##
========================================
  Coverage    68.60%   68.60%           
========================================
  Files         1098     1098           
  Lines        43319    43319           
  Branches     11557    11557           
========================================
  Hits         29719    29719           
  Misses       13600    13600

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewwalsh0 matthewwalsh0 merged commit 7b05334 into develop Mar 13, 2024
@matthewwalsh0 matthewwalsh0 deleted the doc/confirmations-approval-flows-result-pages branch March 13, 2024 11:14
@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2024
@metamaskbot metamaskbot added the release-11.14.0 Issue or pull request that will be included in release 11.14.0 label Mar 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@OGPoyraz OGPoyraz OGPoyraz approved these changes

@vinistevam vinistevam vinistevam approved these changes

Assignees

No one assigned

Labels

release-11.14.0 Issue or pull request that will be included in release 11.14.0 team-confirmations-system-deprecated DEPRECATED: please use "team-confirmations" instead

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@matthewwalsh0 @metamaskbot @OGPoyraz @vinistevam