Skip to content

test: disable ppom e2e tests temporarily#23103

Merged
HowardBraham merged 2 commits intodevelopfrom
e2e-disable-ppom
Feb 21, 2024
Merged

test: disable ppom e2e tests temporarily#23103
HowardBraham merged 2 commits intodevelopfrom
e2e-disable-ppom

Conversation

@seaona
Copy link
Copy Markdown
Member

@seaona seaona commented Feb 21, 2024 •
edited
Loading

Description

Disable ppom tests until cdn responses are mocked.
This unblocks ci.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

Check ci jobs

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 21, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@seaona seaona added the team-confirmations-secure-ux-PR PRs from the confirmations team label Feb 21, 2024
@adonesky1
Copy link
Copy Markdown
Contributor

adonesky1 commented Feb 21, 2024

Lint failing because of the skips 😢

@seaona
Copy link
Copy Markdown
Member Author

seaona commented Feb 21, 2024

oops! it should be okay now 🙏

@seaona seaona marked this pull request as ready for review February 21, 2024 21:30
@seaona seaona requested a review from a team as a code owner February 21, 2024 21:30
@HowardBraham
Copy link
Copy Markdown
Contributor

HowardBraham commented Feb 21, 2024

@adonesky1 this is passing CI now

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Feb 21, 2024

Builds ready [62feafb]
Page Load Metrics (1993 ± 140 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint893911956933
domContentLoaded1095342110
load161925121993292140
domInteractive1095342110
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@HowardBraham HowardBraham merged commit 4c5391d into develop Feb 21, 2024
@HowardBraham HowardBraham deleted the e2e-disable-ppom branch February 21, 2024 22:29
@github-actions github-actions bot locked and limited conversation to collaborators Feb 21, 2024
@metamaskbot metamaskbot added release-11.12.0 Issue or pull request that will be included in release 11.12.0 release-11.11.0 Issue or pull request that will be included in release 11.11.0 and removed release-11.12.0 Issue or pull request that will be included in release 11.12.0 labels Feb 21, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Feb 23, 2024

Missing release label release-11.11.0 on PR. Adding release label release-11.11.0 on PR and removing other release labels(release-11.12.0), as PR was cherry-picked in branch 11.11.0.

@metamaskbot metamaskbot added release-11.10.1 Issue or pull request that will be included in release 11.10.1 and removed release-11.11.0 Issue or pull request that will be included in release 11.11.0 labels Feb 27, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Feb 27, 2024

Missing release label release-11.10.1 on PR. Adding release label release-11.10.1 on PR and removing other release labels(release-11.11.0), as PR was cherry-picked in branch 11.10.1.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@HowardBraham HowardBraham HowardBraham approved these changes

@adonesky1 adonesky1 adonesky1 approved these changes

Assignees

No one assigned

Labels

release-11.10.1 Issue or pull request that will be included in release 11.10.1 team-confirmations-secure-ux-PR PRs from the confirmations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@seaona @adonesky1 @HowardBraham @metamaskbot