chore: upgrading design tokens package that includes dynamic theming#23101
Merged
georgewrmarshall merged 2 commits intodevelopfrom Feb 22, 2024
Merged
chore: upgrading design tokens package that includes dynamic theming#23101georgewrmarshall merged 2 commits intodevelopfrom
georgewrmarshall merged 2 commits intodevelopfrom
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
darkwing
approved these changes
Feb 21, 2024
garrettbear
approved these changes
Feb 21, 2024
Collaborator
Builds ready [88de57c]
Page Load Metrics (1862 ± 151 ms)
Bundle size diffs
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR upgrades the
@metamask/design-tokenspackage to version 2.1.1, which introduces an enhancement for dynamic theming support. With this update, components can now be wrapped in parent containers tagged withdata-theme="light"ordata-theme="dark"attributes, allowing for seamless theme changes that respect the specified theme at any level of nesting. This improvement addresses the need for more flexible theming options within our application, ensuring that theme consistency is maintained across different UI components regardless of their hierarchical structure.Related issues
Related: MetaMask/design-tokens#626
Manual testing steps
Boxcomponents having differentdata-themeattributes.Boxcomponent correctly displays its theme according to thedata-themeattribute, demonstrating the dynamic theming capability.Provided template in
ui/components/component-library/text/text.stories.tsxScreenshots/Recordings
Before
before1080.mov
After
after1080.mov
Pre-merge author checklist
Pre-merge reviewer checklist