chore: disabling static color hex stylelint rule for specific files#23098
Merged
HowardBraham merged 4 commits intodevelopfrom Feb 21, 2024
Merged
chore: disabling static color hex stylelint rule for specific files#23098HowardBraham merged 4 commits intodevelopfrom
HowardBraham merged 4 commits intodevelopfrom
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
garrettbear
approved these changes
Feb 21, 2024
Contributor
|
This has been annoying me recently, so this is great! But let's follow the conventions for giving a disable reason: https://eslint.org/docs/latest/use/configure/rules#comment-descriptions |
Contributor
Author
Great suggestion @HowardBraham! But unfortunately as we've discovered, our version of stylelint doesn't support comments in this way. I'll create an issue to upgrade stylelint in the extension #23099
|
brad-decker
approved these changes
Feb 21, 2024
HowardBraham
approved these changes
Feb 21, 2024
Collaborator
Builds ready [4ced295]
Page Load Metrics (1944 ± 97 ms)
Bundle size diffs
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
This PR addresses the need to refine our linting process by excluding specific files from the 'color-no-hex' rule, as outlined in Issue #23097. The motivation behind this change is to prevent lint warning blindness among developers by focusing on meaningful lint warnings that are relevant to the main application. By updating our lint configuration to ignore certain files where static hex color values are permissible, we aim to maintain the effectiveness of our linting process while acknowledging the unique requirements of standalone or external parts of our project.
Improvement/Solution
Related issues
Fixes: #23097
Manual testing steps
yarn lintScreenshots/Recordings
Before
Below screencast shows warnings that should be ignored
before1080.mov
After
Below screencast shows no more stylelint warnings for static hex
after1080.mov
Linting still works as intended for other files
after.linting1080.mov
Pre-merge author checklist
Pre-merge reviewer checklist
This PR template is filled out with a concise description of the changes, the motivation behind them, and the solution provided. It also includes a link to the related issue, outlines the manual testing steps, and adheres to the pre-merge checklists for both the author and the reviewer.