test: mock cdn response files by seaona · Pull Request #23062 · MetaMask/metamask-extension

seaona · 2024-02-20T10:20:17Z

Description

Particularities of these mocks:

since the returned cdn files are signed, we should make sure that the validateSignature works. For that, we should mock both the response headers and the response body of the requests
we first mock the ppom-version.json response, which contains the version, checksum, signature, hashSignature for each file and each supported chain
we mock the 3 cdn response for the config, stale and stale_diff files
- the response is compressed in Brotli
- we need to mock the return headers too, with the correct Etag. The rest of the headers can be omitted

Next steps:

Re-enable tests [e2e] PPOM - Re-enable all specs after cdn mocks have been implemented #23642
- Some specs might need to update the warning description
- Some specs might need to update the RPC mocks
- Re-enable specs for multichain build: this needs some extra work as the logic for Send multichain needs to be added (it was outdated)
Add a script to update the mock files automatically [e2e] Infra - PPOM - Add script to update the cdn mock files automatically #23640
Implement an e2e test case for verifying that the migration to a new version files works correctly [e2e] PPOM - Add spec for testing a cdn files update #23641

Related issues

Fixes: #23639

Manual testing steps

Check ci jobs

Screenshots/Recordings

Response data compressed (Brotli)

Pre-merge author checklist

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-02-20T10:20:30Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

seaona · 2024-03-22T09:22:40Z

test/e2e/tests/ppom/ppom-blockaid-alert-simple-send.spec.js

-          '0x985c30949c92df7a0bd42e0f3e3d539ece98db24',
-          '1',
-        );
+        await sendScreenToConfirmScreen(driver, mockMaliciousAddress, '1');


for some reason, the address set previously was not the malicious address. Here I fixed it by adding the malicious address

seaona · 2024-03-22T09:36:46Z

test/e2e/tests/ppom/ppom-blockaid-alert-simple-send.spec.js

+  it('should not show security alerts for benign requests', async function () {
+    if (process.env.MULTICHAIN) {
+      return;
+    }


the flow for the multichain build needs to be updated altogether. It's left out of scope of this PR, since this purely focuses on enabling mocks. The update multichain flow should be tackled in a subsequent PR (see description)

codecov · 2024-03-22T09:53:52Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.57%. Comparing base (a246dc3) to head (4dcffb1).
Report is 1 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #23062   +/-   ##
========================================
  Coverage    68.57%   68.57%           
========================================
  Files         1163     1163           
  Lines        44134    44134           
  Branches     11813    11813           
========================================
  Hits         30262    30262           
  Misses       13872    13872

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

seaona · 2024-03-22T10:10:30Z

test/e2e/mock-cdn/cdn-config-res-headers.json

@@ -0,0 +1,3 @@
+{
+  "Etag": "bb28e40153ff052671b8ad835d368d89"


only the etag is needed to verify the file signature

metamaskbot · 2024-03-22T10:49:15Z

Builds ready [4dcffb1]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (811 ± 548 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	69	240	125	43	21
		domContentLoaded	12	58	24	13	6
		load	56	3589	811	1142	548
		domInteractive	12	58	24	13	6

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-03-26T00:10:58Z

Missing release label release-11.14.0 on PR. Adding release label release-11.14.0 on PR and removing other release labels(release-11.14.1), as PR was added to branch 11.14.0 when release was cut.

mock cdn response files draft

055cdef

seaona added the team-confirmations-secure-ux-PR PRs from the confirmations team label Feb 20, 2024

seaona and others added 7 commits February 22, 2024 10:05

added ppom version response mock

9f4bf87

add missing headers

cbd6120

update cdn mock files and headers

258961f

Merge branch 'develop' into test-mock-cdn

a9c54da

re-enable spec

73c1dd3

fix lint

2c09c26

skip multichain

77d319d

seaona commented Mar 22, 2024

View reviewed changes

disable multichain

a2725d6

seaona commented Mar 22, 2024

View reviewed changes

seaona marked this pull request as ready for review March 22, 2024 09:37

seaona requested a review from a team as a code owner March 22, 2024 09:37

seaona mentioned this pull request Mar 22, 2024

[e2e] PPOM - Re-enable all specs after cdn mocks have been implemented #23642

Closed

9 tasks

remove eslint comment

4dcffb1

seaona commented Mar 22, 2024

View reviewed changes

jpuri approved these changes Mar 22, 2024

View reviewed changes

blackdevelopa approved these changes Mar 22, 2024

View reviewed changes

cryptotavares approved these changes Mar 22, 2024

View reviewed changes

pedronfigueiredo approved these changes Mar 22, 2024

View reviewed changes

seaona merged commit fd6b6ca into develop Mar 22, 2024

seaona deleted the test-mock-cdn branch March 22, 2024 12:38

github-actions bot locked and limited conversation to collaborators Mar 22, 2024

metamaskbot added release-11.14.1 Issue or pull request that will be included in release 11.14.1 release-11.14.0 Issue or pull request that will be included in release 11.14.0 and removed release-11.14.1 Issue or pull request that will be included in release 11.14.1 labels Mar 22, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: mock cdn response files#23062

test: mock cdn response files#23062
seaona merged 10 commits intodevelopfrom
test-mock-cdn

seaona commented Feb 20, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Feb 20, 2024

Uh oh!

seaona Mar 22, 2024

Uh oh!

seaona Mar 22, 2024

Uh oh!

codecov bot commented Mar 22, 2024 •

edited

Loading

Uh oh!

seaona Mar 22, 2024

Uh oh!

metamaskbot commented Mar 22, 2024

Uh oh!

metamaskbot commented Mar 26, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

seaona commented Feb 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Feb 20, 2024

Uh oh!

seaona Mar 22, 2024

Choose a reason for hiding this comment

Uh oh!

seaona Mar 22, 2024

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Mar 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

seaona Mar 22, 2024

Choose a reason for hiding this comment

Uh oh!

metamaskbot commented Mar 22, 2024

Uh oh!

metamaskbot commented Mar 26, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

seaona commented Feb 20, 2024 •

edited

Loading

codecov bot commented Mar 22, 2024 •

edited

Loading