You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It seems that the description response for the malicious mocked requests has changed in a recent update.
This PR aims to fix the e2e tests.
This also reveals the strong need for using a stable version of the cdn, by:
Either using the cdn test version of ppom (stable), like we used to do --> that was changed due to some issue Blockaid had on their end
Or mocking the cdn responses and keep them always the same --> to investigate if this is doable, since the responses that we get are in a "weird format" (see example below)
Another scenario to explore for some of these specs, would be to see if we can inject the files directly in the ppomDB. In the same way we initialize the wallet with a certain state, we could initialize the wallet with the ppomDB prefilled in storage.
This PR however, aims to unblock ci in the fastes possible way
I've clearly explained what problem this PR is solving and how it is solved.
I've linked related issues
I've included manual testing steps
I've included screenshots/recordings if applicable
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
I’ve properly set the pull request status:
In case it's not yet "ready for review", I've set it to "draft".
In case it's "ready for review", I've changed it from "draft" to "non-draft".
Pre-merge reviewer checklist
I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Missing release label release-11.11.0 on PR. Adding release label release-11.11.0 on PR and removing other release labels(release-11.12.0), as PR was cherry-picked in branch 11.11.0.
Missing release label release-11.10.1 on PR. Adding release label release-11.10.1 on PR and removing other release labels(release-11.11.0), as PR was cherry-picked in branch 11.10.1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It seems that the description response for the malicious mocked requests has changed in a recent update.
This PR aims to fix the e2e tests.
This also reveals the strong need for using a stable version of the cdn, by:
Another scenario to explore for some of these specs, would be to see if we can inject the files directly in the ppomDB. In the same way we initialize the wallet with a certain state, we could initialize the wallet with the ppomDB prefilled in storage.
This PR however, aims to unblock ci in the fastes possible way
Related issues
Fixes: #23053
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist