Skip to content

test: fix several ppom testcases due to description change#23052

Merged
seaona merged 3 commits intodevelopfrom
e2e-fix-ppom
Feb 19, 2024
Merged

test: fix several ppom testcases due to description change#23052
seaona merged 3 commits intodevelopfrom
e2e-fix-ppom

Conversation

@seaona
Copy link
Copy Markdown
Member

@seaona seaona commented Feb 19, 2024

Description

It seems that the description response for the malicious mocked requests has changed in a recent update.
This PR aims to fix the e2e tests.

This also reveals the strong need for using a stable version of the cdn, by:

  • Either using the cdn test version of ppom (stable), like we used to do --> that was changed due to some issue Blockaid had on their end
  • Or mocking the cdn responses and keep them always the same --> to investigate if this is doable, since the responses that we get are in a "weird format" (see example below)
    Screenshot from 2024-02-19 19-23-25

Another scenario to explore for some of these specs, would be to see if we can inject the files directly in the ppomDB. In the same way we initialize the wallet with a certain state, we could initialize the wallet with the ppomDB prefilled in storage.

This PR however, aims to unblock ci in the fastes possible way

Related issues

Fixes: #23053

Manual testing steps

  1. Check ci or run them locally

Screenshots/Recordings

Before

Screenshot from 2024-02-19 19-04-44

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@seaona seaona added the team-confirmations-secure-ux-PR PRs from the confirmations team label Feb 19, 2024
@seaona seaona marked this pull request as ready for review February 19, 2024 18:18
@seaona seaona requested a review from a team as a code owner February 19, 2024 18:18
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2cbedb4) 68.48% compared to head (1066506) 68.48%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #23052   +/-   ##
========================================
  Coverage    68.48%   68.48%           
========================================
  Files         1089     1089           
  Lines        43015    43015           
  Branches     11462    11462           
========================================
  Hits         29455    29455           
  Misses       13560    13560           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [1066506]
Page Load Metrics (975 ± 67 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1254841927435
domContentLoaded997382813
load804146597513867
domInteractive997382813
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@seaona seaona merged commit 7107841 into develop Feb 19, 2024
@seaona seaona deleted the e2e-fix-ppom branch February 19, 2024 18:58
@github-actions github-actions bot locked and limited conversation to collaborators Feb 19, 2024
@metamaskbot metamaskbot added release-11.12.0 Issue or pull request that will be included in release 11.12.0 release-11.11.0 Issue or pull request that will be included in release 11.11.0 and removed release-11.12.0 Issue or pull request that will be included in release 11.12.0 labels Feb 19, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

Missing release label release-11.11.0 on PR. Adding release label release-11.11.0 on PR and removing other release labels(release-11.12.0), as PR was cherry-picked in branch 11.11.0.

@metamaskbot metamaskbot added release-11.10.1 Issue or pull request that will be included in release 11.10.1 and removed release-11.11.0 Issue or pull request that will be included in release 11.11.0 labels Feb 27, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

Missing release label release-11.10.1 on PR. Adding release label release-11.10.1 on PR and removing other release labels(release-11.11.0), as PR was cherry-picked in branch 11.10.1.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-11.10.1 Issue or pull request that will be included in release 11.10.1 team-confirmations-secure-ux-PR PRs from the confirmations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test - PPOM e2e are failing due to description update for malicious requests being mocked

4 participants