feat: UX - Multichain - Disconnect All Modal#23032
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
Builds ready [bcffd2c]
Page Load Metrics (783 ± 410 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #23032 +/- ##
========================================
Coverage 68.72% 68.72%
========================================
Files 1122 1123 +1
Lines 43577 43581 +4
Branches 11661 11661
========================================
+ Hits 29945 29949 +4
Misses 13632 13632 ☔ View full report in Codecov by Sentry. |
NidhiKJha
approved these changes
Mar 12, 2024
jonybur
suggested changes
Mar 12, 2024
| const t = useI18nContext(); | ||
|
|
||
| return ( | ||
| <Modal isOpen onClose={onClose}> |
Contributor
There was a problem hiding this comment.
Please add a data-test-id or classname
Member
There was a problem hiding this comment.
Since, this is a skeleton. We are gonna do that once we integrate this modal on button click
jonybur
approved these changes
Mar 12, 2024
vthomas13
approved these changes
Mar 12, 2024
Collaborator
Builds ready [8ebb9ea]
Page Load Metrics (1001 ± 401 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Creates a simple Disconnect All modal which can be used for both Accounts and Snaps
Related issues
Fixes: 2212
Fixes: 2212
Manual testing steps
Screenshots/Recordings
Before
NA
After
Pre-merge author checklist
Pre-merge reviewer checklist