Skip to content

fix: Remove unnecessary resolution for socks#22960

Merged
HowardBraham merged 2 commits intodevelopfrom
fix/fix-dependency
Feb 15, 2024
Merged

fix: Remove unnecessary resolution for socks#22960
HowardBraham merged 2 commits intodevelopfrom
fix/fix-dependency

Conversation

@sahar-fehri
Copy link
Copy Markdown
Contributor

@sahar-fehri sahar-fehri commented Feb 14, 2024 •
edited by Gudahtt
Loading

Description

Remove unnecessary resolution for the socks package. This removes the risk of the resolution causing problems in future updates, reducing maintenance burdens for the team.

Related issues

N/A

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@sahar-fehri sahar-fehri requested a review from a team as a code owner February 14, 2024 20:37
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 14, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sahar-fehri sahar-fehri added the team-core-extension-ux Core Extension UX team label Feb 14, 2024
@HowardBraham
Copy link
Copy Markdown
Contributor

HowardBraham commented Feb 14, 2024

@sahar-fehri are you sure that v2.8.0 is correct? It looks like latest is still v2.7.3

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Feb 14, 2024

Builds ready [c32f85f]
Page Load Metrics (1132 ± 54 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1382831944220
domContentLoaded899342713
load8551414113211254
domInteractive899342713
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (12a0770) 68.54% compared to head (c32f85f) 68.54%.
Report is 1 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #22960   +/-   ##
========================================
  Coverage    68.54%   68.54%           
========================================
  Files         1088     1088           
  Lines        42904    42904           
  Branches     11413    11413           
========================================
  Hits         29408    29408           
  Misses       13496    13496

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Gudahtt
Gudahtt approved these changes Feb 14, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt changed the title Fix/fix dependency fix: Remove unnecessary resolution Feb 14, 2024
@Gudahtt
Copy link
Copy Markdown
Member

Gudahtt commented Feb 14, 2024

I've updated the PR title and description to explain the change better as well; feel free to edit further, just my suggestions.

@HowardBraham HowardBraham changed the title fix: Remove unnecessary resolution fix: Remove unnecessary resolution for socks Feb 15, 2024
@HowardBraham HowardBraham merged commit 9c59da5 into develop Feb 15, 2024
@HowardBraham HowardBraham deleted the fix/fix-dependency branch February 15, 2024 00:18
@github-actions github-actions bot locked and limited conversation to collaborators Feb 15, 2024
@metamaskbot metamaskbot added release-11.12.0 Issue or pull request that will be included in release 11.12.0 release-11.11.0 Issue or pull request that will be included in release 11.11.0 and removed release-11.12.0 Issue or pull request that will be included in release 11.12.0 labels Feb 15, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Feb 21, 2024

Missing release label release-11.11.0 on PR. Adding release label release-11.11.0 on PR and removing other release labels(release-11.12.0), as PR was cherry-picked in branch 11.11.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@HowardBraham HowardBraham HowardBraham approved these changes

@Gudahtt Gudahtt Gudahtt approved these changes

Assignees

No one assigned

Labels

release-11.11.0 Issue or pull request that will be included in release 11.11.0 team-core-extension-ux Core Extension UX team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sahar-fehri @HowardBraham @metamaskbot @Gudahtt