Skip to content

Fix memoisation base transaction confirmation container#22944

Merged
OGPoyraz merged 1 commit intodevelopfrom
fix-memoisation-base-tx-confirmation-container
Feb 14, 2024
Merged

Fix memoisation base transaction confirmation container#22944
OGPoyraz merged 1 commit intodevelopfrom
fix-memoisation-base-tx-confirmation-container

Conversation

@OGPoyraz
Copy link
Copy Markdown
Member

@OGPoyraz OGPoyraz commented Feb 14, 2024 •
edited
Loading

Description

While fixing send max eth feature on #22694, hexTransactionAmount is forgotten to include in the memoisation process of the base transaction confirmation container. This PR aims to take this recalculated value in to account on selector process.

Related issues

Related: #22694

Manual testing steps

N/A

Screenshots/Recordings

Before

N/A

After

N/A

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@OGPoyraz
Ensure that calculated hexTransactionAmount is integrated into the ba…
d0398da 
…se confirmation container memoization selector process
@OGPoyraz OGPoyraz requested a review from a team as a code owner February 14, 2024 13:36
@OGPoyraz OGPoyraz added team-confirmations-system-deprecated DEPRECATED: please use "team-confirmations" instead team-snaps-deprecated DEPRECATED: please use "team-core-platform" instead labels Feb 14, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (391e9e7) 68.55% compared to head (d0398da) 68.55%.
Report is 1 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #22944   +/-   ##
========================================
  Coverage    68.55%   68.55%           
========================================
  Files         1088     1088           
  Lines        42907    42908    +1     
  Branches     11415    11416    +1     
========================================
+ Hits         29411    29412    +1     
  Misses       13496    13496

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Feb 14, 2024

Builds ready [d0398da]
Page Load Metrics (1130 ± 93 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1245852109244
domContentLoaded990352813
load9361703113019493
domInteractive990352813
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 103 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

FrederikBolding
FrederikBolding approved these changes Feb 14, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@FrederikBolding FrederikBolding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for the quick fix 🙌

@OGPoyraz OGPoyraz merged commit f8b59c7 into develop Feb 14, 2024
@OGPoyraz OGPoyraz deleted the fix-memoisation-base-tx-confirmation-container branch February 14, 2024 14:55
@github-actions github-actions bot locked and limited conversation to collaborators Feb 14, 2024
@metamaskbot metamaskbot added the release-11.12.0 Issue or pull request that will be included in release 11.12.0 label Feb 14, 2024
@ziedbrini ziedbrini added team-snaps-platform-deprecated DEPRECATED: please use "team-core-platform" instead (or "team-new-networks" for Solana snap issues) and removed team-snaps-deprecated DEPRECATED: please use "team-core-platform" instead labels Mar 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@FrederikBolding FrederikBolding FrederikBolding approved these changes

@vinistevam vinistevam vinistevam approved these changes

Assignees

No one assigned

Labels

release-11.12.0 Issue or pull request that will be included in release 11.12.0 team-confirmations-system-deprecated DEPRECATED: please use "team-confirmations" instead team-snaps-platform-deprecated DEPRECATED: please use "team-core-platform" instead (or "team-new-networks" for Solana snap issues)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@OGPoyraz @metamaskbot @FrederikBolding @vinistevam @ziedbrini