Fixes an issue cancelling a permission request#22915
Merged
FrederikBolding merged 1 commit intodevelopfrom Feb 13, 2024
Merged
Conversation
david0xd
approved these changes
Feb 13, 2024
Collaborator
Builds ready [a87e5ab]
Page Load Metrics (1134 ± 57 ms)
Bundle size diffs
|
hmalik88
approved these changes
Feb 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I introduced a bug in #22850 which can be reproduced by going to the test-dapp, starting a permission request flow, proceeding to the next screen and cancelling it again. This fixes the problem by guarding against
permissionsbeingnull.Manual testing steps