Add networkClientId to DetectTokensController.detectNewTokens()#22898
Merged
Add networkClientId to DetectTokensController.detectNewTokens()#22898
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
13 tasks
bergeron
previously approved these changes
Feb 13, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #22898 +/- ##
===========================================
- Coverage 68.54% 68.54% -0.00%
===========================================
Files 1088 1088
Lines 42900 42904 +4
Branches 11418 11419 +1
===========================================
+ Hits 29403 29405 +2
- Misses 13497 13499 +2 ☔ View full report in Codecov by Sentry. |
Collaborator
Builds ready [2cd0d7a]
Page Load Metrics (989 ± 48 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
shanejonas
approved these changes
Feb 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently networkClientId token based polling in the
DetectTokensControllerdoes not make thegetBalancesInSingleCallcontract call with the provider for the networkClientId. This is because networkClientId is not being passed from_executePolltogetBalancesInSingleCall.This PR adds an optional networkClientId param to
detectNewTokenswhich is used to:getBalancesInSingleCallcalls with the correct providerRelated issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2097
Manual testing steps
Nothing should change as this does not affect the current single globally selected network flow and the multichain polling for this has not been integrated yet.
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist