Skip to content

fix: gas fee editing should not be hidden if user has disabled currency rate check#22890

Merged
jpuri merged 2 commits intodevelopfrom
edit_gas_fee_fix
Feb 12, 2024
Merged

fix: gas fee editing should not be hidden if user has disabled currency rate check#22890
jpuri merged 2 commits intodevelopfrom
edit_gas_fee_fix

Conversation

@jpuri
Copy link
Copy Markdown
Contributor

@jpuri jpuri commented Feb 9, 2024

Description

Gas editing button is hidden if user disabled currency rate check option.

Related issues

Fixes: #22872

Manual testing steps

  1. Go to security settings and disable Show balance and token price checker
  2. Create a transaction
  3. Ensure that option to edit has fee should be available

Screenshots/Recordings

Screenshot 2024-02-09 at 6 33 04 PM

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added team-confirmations-secure-ux-deprecated DEPRECATED: please use "team-confirmations" instead needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Feb 9, 2024
@jpuri jpuri requested a review from a team as a code owner February 9, 2024 15:07
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 9, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Feb 9, 2024

Builds ready [7ee42cc]
Page Load Metrics (852 ± 37 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint861621152412
domContentLoaded105326157
load72810288527637
domInteractive105326157
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@bschorchit bschorchit added team-confirmations-secure-ux-PR PRs from the confirmations team and removed team-confirmations-secure-ux-deprecated DEPRECATED: please use "team-confirmations" instead labels Feb 9, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Feb 12, 2024

Builds ready [848fc7b]
Page Load Metrics (1175 ± 105 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint12066822711254
domContentLoaded11155393316
load97518821175220105
domInteractive11155393316
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (480a671) 68.51% compared to head (848fc7b) 68.51%.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #22890   +/-   ##
========================================
  Coverage    68.51%   68.51%           
========================================
  Files         1088     1088           
  Lines        42914    42915    +1     
  Branches     11426    11427    +1     
========================================
+ Hits         29399    29401    +2     
+ Misses       13515    13514    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jpuri jpuri merged commit b8e7bb9 into develop Feb 12, 2024
@jpuri jpuri deleted the edit_gas_fee_fix branch February 12, 2024 08:15
@github-actions github-actions bot locked and limited conversation to collaborators Feb 12, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 12, 2024
@metamaskbot metamaskbot added release-11.12.0 Issue or pull request that will be included in release 11.12.0 release-11.9.3 Issue or pull request that will be included in release 11.9.3 and removed release-11.12.0 Issue or pull request that will be included in release 11.12.0 labels Feb 12, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Feb 12, 2024

Missing release label release-11.9.3 on PR. Adding release label release-11.9.3 on PR and removing other release labels(release-11.12.0), as PR was cherry-picked in branch 11.9.3.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@segun segun segun approved these changes

@danjm danjm danjm approved these changes

@blackdevelopa blackdevelopa blackdevelopa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-11.9.3 Issue or pull request that will be included in release 11.9.3 team-confirmations-secure-ux-PR PRs from the confirmations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Metamask 11.9.0 - can not change gas option or value any more

6 participants

@jpuri @metamaskbot @segun @danjm @blackdevelopa @bschorchit