Skip to content

[MMI] Fixes PW e2e tests (snapshots)#22883

Merged
HowardBraham merged 4 commits intodevelopfrom
MMI-fix-pw-tests
Feb 9, 2024
Merged

[MMI] Fixes PW e2e tests (snapshots)#22883
HowardBraham merged 4 commits intodevelopfrom
MMI-fix-pw-tests

Conversation

@zone-live
Copy link
Copy Markdown
Contributor

@zone-live zone-live commented Feb 8, 2024

Description

Fixes MMI playwright snapshots from tests.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@zone-live zone-live added the mmi DEPRECATED: The product got sunset label Feb 8, 2024
@zone-live zone-live requested a review from a team as a code owner February 8, 2024 22:34
@zone-live zone-live requested a review from darkwing February 8, 2024 22:34
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 8, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Feb 8, 2024

Builds ready [2a5f10a]
Page Load Metrics (788 ± 24 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint78132100136
domContentLoaded10431773
load6999087885024
domInteractive10431773
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (201a48f) 68.51% compared to head (737efdf) 68.51%.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #22883   +/-   ##
========================================
  Coverage    68.51%   68.51%           
========================================
  Files         1088     1088           
  Lines        42914    42914           
  Branches     11426    11426           
========================================
  Hits         29399    29399           
  Misses       13515    13515

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Feb 9, 2024

Builds ready [737efdf]
Page Load Metrics (851 ± 41 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint85143105157
domContentLoaded13402063
load75110778518641
domInteractive13402063
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@zone-live
Copy link
Copy Markdown
Contributor Author

zone-live commented Feb 9, 2024

Hi @darkwing 👋🏼 When you can please feel free to merge this PR 👍🏼 Thank you!

@HowardBraham HowardBraham merged commit 926594f into develop Feb 9, 2024
@HowardBraham HowardBraham deleted the MMI-fix-pw-tests branch February 9, 2024 20:03
@github-actions github-actions bot locked and limited conversation to collaborators Feb 9, 2024
@metamaskbot metamaskbot added the release-11.12.0 Issue or pull request that will be included in release 11.12.0 label Feb 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@HowardBraham HowardBraham HowardBraham approved these changes

@darkwing darkwing Awaiting requested review from darkwing

+1 more reviewer

@albertolive albertolive albertolive approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

mmi DEPRECATED: The product got sunset release-11.12.0 Issue or pull request that will be included in release 11.12.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zone-live @metamaskbot @HowardBraham @albertolive