You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The purpose of this PR is to enable Snaps Dynamic Permissions feature.
This PR adds missing hooks required by the Dynamic Permissions feature and adds additional changes to the UI to correctly support Dynamic Permissions requests in approval popup.
I've clearly explained what problem this PR is solving and how it is solved.
I've linked related issues
I've included manual testing steps
I've included screenshots/recordings if applicable
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
I’ve properly set the pull request status:
In case it's not yet "ready for review", I've set it to "draft".
In case it's "ready for review", I've changed it from "draft" to "non-draft".
Pre-merge reviewer checklist
I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
❗ Current head 8ab3ece differs from pull request most recent head cc930be. Consider uploading reports for the commit cc930be to get more accurate results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
background: 184 Bytes (0.01%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)
david0xd
changed the title
Add changes required for Snaps dynamic permissions
feat(Snaps Dynamic Permissions): Add changes to support Snaps dynamic permissions integration
Feb 14, 2024
david0xd
changed the title
feat(Snaps Dynamic Permissions): Add changes to support Snaps dynamic permissions integration
feat(Snaps Dynamic Permissions): Adds support for Snaps dynamic permissions
Feb 14, 2024
This PR has been automatically marked as stale because it has not had recent activity in the last 60 days. It will be closed in 14 days. Thank you for your contributions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DO-NOT-MERGEPull requests that should not be mergedstaleissues and PRs marked as staleteam-snaps-platform-deprecatedDEPRECATED: please use "team-core-platform" instead (or "team-new-networks" for Solana snap issues)
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The purpose of this PR is to enable Snaps Dynamic Permissions feature.
This PR adds missing hooks required by the
Dynamic Permissionsfeature and adds additional changes to the UI to correctly support Dynamic Permissions requests in approval popup.Related PR: MetaMask/snaps#2088
Dynamic Permissions feature is specified in SIP-14.
Rules to follow before merging this PR
Merge this PR only into the release PR of Snaps packages that contain changes on the related PR for Snaps packages: MetaMask/snaps#2088
Target PR: Snaps packages release.
TODO: Change target PR to the one that releases
Snapspackages withDynamic Permissions.Related issues
Related task: MetaMask/snaps#1821
Manual testing steps
snap_requestPermissions,snap_getPermissions,snap_revokePermissions.Snap code examples:
Screenshots/Recordings
Before
TODO: Show to related screens which have the code living in the same components, etc.
After
End to end testing TODO
Dynamic Permissionsfeatures (all three methods).Dynamic Permissionsrequests.Pre-merge author checklist
Pre-merge reviewer checklist