Skip to content

chore: Bump @metamask/address-book-controller#22863

Merged
HowardBraham merged 2 commits intoMetaMask:developfrom
legobeat:deps-address-book-controller
Mar 19, 2024
Merged

chore: Bump @metamask/address-book-controller#22863
HowardBraham merged 2 commits intoMetaMask:developfrom
legobeat:deps-address-book-controller

Conversation

@legobeat
Copy link
Copy Markdown
Contributor

@legobeat legobeat commented Feb 7, 2024 •
edited
Loading

Description

  • Bump dependency @metamask/address-book-controller from 3.0.0 to 3.1.7
  • Fix out-of-sync yarn.lock causing prep-deps to fail

Removes some older versions of transitive dependencies.

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 7, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@legobeat legobeat added dependencies Pull requests that update a dependency file team-application-security Application security team labels Feb 7, 2024
@legobeat legobeat force-pushed the deps-address-book-controller branch from 6afdd44 to e310e52 Compare February 7, 2024 22:15
@legobeat legobeat marked this pull request as ready for review February 8, 2024 08:51
@legobeat legobeat requested review from a team as code owners February 8, 2024 08:51
@legobeat legobeat force-pushed the deps-address-book-controller branch from a821a21 to d78ae24 Compare February 8, 2024 09:10
@legobeat legobeat mentioned this pull request Feb 8, 2024
Closed
13 tasks
Gudahtt
Gudahtt approved these changes Feb 8, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@legobeat legobeat force-pushed the deps-address-book-controller branch 2 times, most recently from 4a0a016 to 62183ef Compare February 8, 2024 18:50
Gudahtt
Gudahtt previously approved these changes Feb 8, 2024
View reviewed changes
@legobeat legobeat force-pushed the deps-address-book-controller branch from 62183ef to 633584a Compare February 8, 2024 20:53
@legobeat legobeat requested a review from a team February 8, 2024 20:53
@legobeat legobeat force-pushed the deps-address-book-controller branch 2 times, most recently from 1bc0b70 to ef7401a Compare February 22, 2024 03:47
@legobeat legobeat requested a review from Gudahtt February 22, 2024 03:52
@legobeat legobeat force-pushed the deps-address-book-controller branch from 30b7b9b to 6783e7b Compare February 22, 2024 10:46
@gauthierpetetin gauthierpetetin added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 22, 2024
@legobeat legobeat force-pushed the deps-address-book-controller branch 8 times, most recently from 2f38f3a to 4bd1942 Compare February 28, 2024 15:09
@legobeat legobeat force-pushed the deps-address-book-controller branch from e840e31 to 6d14576 Compare March 6, 2024 23:15
@legobeat legobeat requested a review from mcmire March 6, 2024 23:22
@legobeat legobeat force-pushed the deps-address-book-controller branch 14 times, most recently from 6c61b57 to 8dbd4c1 Compare March 14, 2024 13:12
@legobeat legobeat force-pushed the deps-address-book-controller branch 2 times, most recently from 0702d4f to 081d15c Compare March 18, 2024 21:35
@legobeat legobeat force-pushed the deps-address-book-controller branch from 081d15c to b50faae Compare March 18, 2024 21:51
@legobeat legobeat force-pushed the deps-address-book-controller branch from b50faae to 4a90243 Compare March 18, 2024 22:09
mcmire
mcmire approved these changes Mar 18, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably upgrade to 4.0.1 at some point, but this is definitely better!

@legobeat legobeat requested a review from a team March 18, 2024 22:12
@HowardBraham HowardBraham merged commit 0e76174 into MetaMask:develop Mar 19, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 19, 2024
@metamaskbot metamaskbot added the release-11.14.0 Issue or pull request that will be included in release 11.14.0 label Mar 26, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Mar 26, 2024

No release label on PR. Adding release label release-11.14.0 on PR, as PR was added to branch 11.14.0 when release was cut.

@legobeat legobeat deleted the deps-address-book-controller branch March 27, 2024 05:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mcmire mcmire mcmire approved these changes

@HowardBraham HowardBraham HowardBraham approved these changes

@Gudahtt Gudahtt Awaiting requested review from Gudahtt

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) release-11.14.0 Issue or pull request that will be included in release 11.14.0 team-application-security Application security team

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@legobeat @metamaskbot @mcmire @HowardBraham @Gudahtt @gauthierpetetin