fix: fix selectedAddress and nftController instantiation#22856
Merged
sahar-fehri merged 10 commits intodevelopfrom Feb 13, 2024
Merged
fix: fix selectedAddress and nftController instantiation#22856sahar-fehri merged 10 commits intodevelopfrom
sahar-fehri merged 10 commits intodevelopfrom
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
bergeron
reviewed
Feb 7, 2024
bergeron
reviewed
Feb 7, 2024
danjm
reviewed
Feb 8, 2024
Collaborator
Builds ready [a1558d8]
Page Load Metrics (943 ± 185 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #22856 +/- ##
===========================================
+ Coverage 68.47% 68.47% +0.01%
===========================================
Files 1088 1088
Lines 42956 42962 +6
Branches 11436 11432 -4
===========================================
+ Hits 29410 29417 +7
+ Misses 13546 13545 -1 ☔ View full report in Codecov by Sentry. |
jasonzhouu
reviewed
Feb 9, 2024
| !currentTabIsConnectedToNextAddress; | ||
|
|
||
| try { | ||
| await _setSelectedAddress(address); |
Contributor
There was a problem hiding this comment.
_setSelectedAddress function will switch preferencesController's selected address, even though account is not found in accountsController,
it might cause inconsistent address state between preferencesController and accountsController.
Contributor
Author
There was a problem hiding this comment.
To avoid this inconsistency, we will first check if the account is found first, then we will update the controllers.
If account was not found, no controllers will be updated.
122b25e to
02a751c
Compare
Collaborator
Builds ready [02a751c]
Page Load Metrics (1067 ± 68 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
danjm
approved these changes
Feb 13, 2024
gantunesr
approved these changes
Feb 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Noticed that when you freshly import the extension, usse testDapp to deploy and mint an NFT, then manually import the NFT.
you will be able to see the NFT. Then when you switch to another account and go back to the account that has the NFT;
1- you wont be able to see the NFTs you imported earlier
2- When you try to import them again you will get an error (fired from core when trying to verify ownership)
Noticed that this was due to core having the wrong userAddress to check ownership for, and then in metamask.js, the selectedAddress retrieved does not match the user's selected Address
This behavior is also reported to be on v11.10.0, on this issue: #22796
Related issues
Fixes: #22796
Fixes: #22798
Manual testing steps
Screenshots/Recordings
Before
devBefore.mov
After
DevAfter.mov
Pre-merge author checklist
Pre-merge reviewer checklist