Skip to content

[test] PPOM - Run Simple Send Eth test against Multichain build#22829

Merged
seaona merged 14 commits intodevelopfrom
ppom-async-multichain
Feb 6, 2024
Merged

[test] PPOM - Run Simple Send Eth test against Multichain build#22829
seaona merged 14 commits intodevelopfrom
ppom-async-multichain

Conversation

@seaona
Copy link
Copy Markdown
Member

@seaona seaona commented Feb 6, 2024 •
edited
Loading

Description

This PR adds the Simple Send Eth PPOM test to be run against Multichain build.
Context: the multichain build changes the Confirmation pages, specifically the Next button is now called Continue, so we need to add this change in the e2e in order to work for multichain

Related issues

Fixes: #22830

Manual testing steps

1.Check circle ci jobs

Screenshots/Recordings

Multichain build:

Screenshot from 2024-02-06 17-50-56

Normal build:

Screenshot from 2024-02-06 17-52-17

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@seaona seaona requested a review from a team as a code owner February 6, 2024 16:19
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 6, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

danjm
danjm previously approved these changes Feb 6, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@danjm danjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! thank-you!

Base automatically changed from ppom-async-poc to develop February 6, 2024 16:26
@danjm danjm dismissed their stale review February 6, 2024 16:26

The base branch was changed.

@seaona seaona added the team-confirmations-secure-ux-deprecated DEPRECATED: please use "team-confirmations" instead label Feb 6, 2024
@seaona seaona changed the title Ppom async multichain [test] PPOM - Run Simple Send Eth test against Multichain build Feb 6, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Feb 6, 2024

Builds ready [7d036c9]
Page Load Metrics (779 ± 40 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint85157109189
domContentLoaded9251542
load70510687798340
domInteractive9251542
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0364739) 68.39% compared to head (7d036c9) 68.39%.
Report is 1 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #22829   +/-   ##
========================================
  Coverage    68.39%   68.39%           
========================================
  Files         1089     1089           
  Lines        42874    42874           
  Branches     11407    11407           
========================================
  Hits         29320    29320           
  Misses       13554    13554

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seaona seaona requested a review from danjm February 6, 2024 17:35
@seaona seaona merged commit 35282e6 into develop Feb 6, 2024
@seaona seaona deleted the ppom-async-multichain branch February 6, 2024 18:13
@github-actions github-actions bot locked and limited conversation to collaborators Feb 6, 2024
@metamaskbot metamaskbot added the release-11.11.0 Issue or pull request that will be included in release 11.11.0 label Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@danjm danjm danjm approved these changes

@digiwand digiwand digiwand approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-11.11.0 Issue or pull request that will be included in release 11.11.0 team-confirmations-secure-ux-deprecated DEPRECATED: please use "team-confirmations" instead

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PPOM - Support simple send ETH testcase to run against Multichain builds

4 participants

@seaona @metamaskbot @danjm @digiwand