Skip to content

UX: Show names for the accounts in Send Flow#22824

Merged
NidhiKJha merged 5 commits intodevelopfrom
send-label-fix
Feb 8, 2024
Merged

UX: Show names for the accounts in Send Flow#22824
NidhiKJha merged 5 commits intodevelopfrom
send-label-fix

Conversation

@NidhiKJha
Copy link
Copy Markdown
Member

@NidhiKJha NidhiKJha commented Feb 6, 2024

This PR is to show the account name when the user search for an account .

Related issues

Fixes:

Manual testing steps

  1. Run extension via MULTICHAIN=1 yarn start
  2. Go to send flow
  3. search for ens account, test.eth
  4. Look both the account name and address shows up

Screenshots/Recordings

Before

Screenshot 2024-02-06 at 3 45 59 PM

After

Screenshot 2024-02-06 at 3 44 32 PM

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@NidhiKJha NidhiKJha added team-core-extension-ux Core Extension UX team needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. labels Feb 6, 2024
@NidhiKJha NidhiKJha requested a review from a team as a code owner February 6, 2024 10:16
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Feb 6, 2024
DDDDDanica
DDDDDanica previously approved these changes Feb 6, 2024
View reviewed changes
darkwing
darkwing previously approved these changes Feb 7, 2024
View reviewed changes
@NidhiKJha NidhiKJha dismissed stale reviews from darkwing and DDDDDanica via 2758b60 February 7, 2024 17:24
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 7, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Feb 7, 2024

Builds ready [56750e4]
Page Load Metrics (790 ± 16 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint882451113316
domContentLoaded9331553
load7118507903416
domInteractive9331553
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 6 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 7, 2024 •
edited
Loading

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (c4c12ec) 68.47% compared to head (2966810) 68.48%.
Report is 1 commits behind head on develop.

Files Patch % Lines
...nts/multichain/pages/send/components/recipient.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #22824      +/-   ##
===========================================
+ Coverage    68.47%   68.48%   +0.01%     
===========================================
  Files         1088     1088              
  Lines        42902    42903       +1     
  Branches     11424    11426       +2     
===========================================
+ Hits         29377    29381       +4     
+ Misses       13525    13522       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NidhiKJha NidhiKJha requested review from a team as code owners February 8, 2024 11:43
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Feb 8, 2024

Builds ready [2966810]
Page Load Metrics (792 ± 41 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint82151105189
domContentLoaded9261652
load68711387928641
domInteractive9261652
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 6 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@NidhiKJha NidhiKJha merged commit 3ac6784 into develop Feb 8, 2024
@NidhiKJha NidhiKJha deleted the send-label-fix branch February 8, 2024 17:03
@github-actions github-actions bot locked and limited conversation to collaborators Feb 8, 2024
@metamaskbot metamaskbot added the release-11.12.0 Issue or pull request that will be included in release 11.12.0 label Feb 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DDDDDanica DDDDDanica Awaiting requested review from DDDDDanica

2 more reviewers

@darkwing darkwing darkwing approved these changes

@vthomas13 vthomas13 vthomas13 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-11.12.0 Issue or pull request that will be included in release 11.12.0 team-core-extension-ux Core Extension UX team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@NidhiKJha @metamaskbot @darkwing @vthomas13 @DDDDDanica